BinEditor: Split out BinEditorDocument class definition

Still preparing data holder re-organization.

Change-Id: I29473fed8320b3812288b72d0d5fc943aa67a2cf
Reviewed-by: David Schulz <david.schulz@qt.io>

src/plugins/bineditor/bineditorplugin.cpp

@@ -75,6 +75,50 @@ using namespace Core;
 
 namespace BinEditor::Internal {
 
+class BinEditorWidget;
+
+class BinEditorDocument : public IDocument
+{
+    Q_OBJECT
+public:
+    BinEditorDocument(BinEditorWidget *parent);
+
+    QByteArray contents() const final;
+    bool setContents(const QByteArray &contents) final;
+
+    ReloadBehavior reloadBehavior(ChangeTrigger state, ChangeType type) const final
+    {
+        return type == TypeRemoved ? BehaviorSilent : IDocument::reloadBehavior(state, type);
+    }
+
+    OpenResult open(QString *errorString, const FilePath &filePath,
+                    const FilePath &realFilePath) final
+    {
+        QTC_CHECK(filePath == realFilePath); // The bineditor can do no autosaving
+        return openImpl(errorString, filePath);
+    }
+
+    OpenResult openImpl(QString *errorString, const FilePath &filePath, quint64 offset = 0);
+
+    void provideData(quint64 address);
+
+    void provideNewRange(quint64 offset)
+    {
+        if (filePath().exists())
+            openImpl(nullptr, filePath(), offset);
+    }
+
+    bool isModified() const final;
+
+    bool isSaveAsAllowed() const final { return true; }
+
+    bool reload(QString *errorString, ReloadFlag flag, ChangeType type) final;
+    bool saveImpl(QString *errorString, const Utils::FilePath &filePath, bool autoSave) final;
+
+private:
+    BinEditorWidget *m_widget;
+};
+
 class BinEditorWidget final : public QAbstractScrollArea, public EditorService
 {
     Q_OBJECT
@@ -2065,13 +2109,11 @@ private:
 };
 
 
-class BinEditorDocument : public IDocument
+// BinEditorDocument
+
+BinEditorDocument::BinEditorDocument(BinEditorWidget *parent)
+    : IDocument(parent)
 {
-    Q_OBJECT
-public:
-    BinEditorDocument(BinEditorWidget *parent) :
-        IDocument(parent)
-    {
     setId(Core::Constants::K_DEFAULT_BINARY_EDITOR_ID);
     setMimeType(Utils::Constants::OCTET_STREAM_MIMETYPE);
     m_widget = parent;
@@ -2079,37 +2121,25 @@ public:
     es->setFetchDataHandler([this](quint64 address) { provideData(address); });
     es->setNewRangeRequestHandler([this](quint64 offset) { provideNewRange(offset); });
     es->setDataChangedHandler([this](quint64, const QByteArray &) { contentsChanged(); });
-    }
+}
 
-    QByteArray contents() const override
-    {
+QByteArray BinEditorDocument::contents() const
+{
     return m_widget->contents();
-    }
+}
 
-    bool setContents(const QByteArray &contents) override
-    {
+bool BinEditorDocument::setContents(const QByteArray &contents)
+{
     m_widget->clear();
     if (!contents.isEmpty()) {
         m_widget->setSizes(0, contents.length(), contents.length());
         m_widget->addData(0, contents);
     }
     return true;
-    }
+}
 
-    ReloadBehavior reloadBehavior(ChangeTrigger state, ChangeType type) const override
-    {
-        return type == TypeRemoved ? BehaviorSilent : IDocument::reloadBehavior(state, type);
-    }
-
-    OpenResult open(QString *errorString, const FilePath &filePath,
-                    const FilePath &realFilePath) override
-    {
-        QTC_CHECK(filePath == realFilePath); // The bineditor can do no autosaving
-        return openImpl(errorString, filePath);
-    }
-
-    OpenResult openImpl(QString *errorString, const FilePath &filePath, quint64 offset = 0)
-    {
+IDocument::OpenResult BinEditorDocument::openImpl(QString *errorString, const FilePath &filePath, quint64 offset)
+{
     const qint64 size = filePath.fileSize();
     if (size < 0) {
         QString msg = Tr::tr("Cannot open %1: %2").arg(filePath.toUserOutput(), Tr::tr("File Error"));
@@ -2146,10 +2176,10 @@ public:
     setFilePath(filePath);
     m_widget->setSizes(offset, size);
     return OpenResult::Success;
-    }
+}
 
-    void provideData(quint64 address)
-    {
+void BinEditorDocument::provideData(quint64 address)
+{
     const FilePath fn = filePath();
     if (fn.isEmpty())
         return;
@@ -2162,25 +2192,16 @@ public:
 //       QMessageBox::critical(ICore::dialogParent(), Tr::tr("File Error"),
 //                             Tr::tr("Cannot open %1: %2").arg(
 //                                   fn.toUserOutput(), file.errorString()));
-    }
+}
 
-    void provideNewRange(quint64 offset)
-    {
-        if (filePath().exists())
-            openImpl(nullptr, filePath(), offset);
-    }
-
-public:
-    bool isModified() const override
-    {
+bool BinEditorDocument::isModified() const
+{
     return isTemporary()/*e.g. memory view*/ ? false
                                              : m_widget->isModified();
-    }
+}
 
-    bool isSaveAsAllowed() const override { return true; }
-
-    bool reload(QString *errorString, ReloadFlag flag, ChangeType type) override
-    {
+bool BinEditorDocument::reload(QString *errorString, ReloadFlag flag, ChangeType type)
+{
     Q_UNUSED(type)
     if (flag == FlagIgnore)
         return true;
@@ -2191,22 +2212,17 @@ public:
     m_widget->setCursorPosition(cPos);
     emit reloadFinished(success);
     return success;
-    }
+}
 
-protected:
-    bool saveImpl(QString *errorString, const Utils::FilePath &filePath, bool autoSave) override
-    {
+bool BinEditorDocument::saveImpl(QString *errorString, const Utils::FilePath &filePath, bool autoSave)
+{
     QTC_ASSERT(!autoSave, return true); // bineditor does not support autosave - it would be a bit expensive
     if (m_widget->save(errorString, this->filePath(), filePath)) {
         setFilePath(filePath);
         return true;
     }
     return false;
-    }
-
-private:
-    BinEditorWidget *m_widget;
-};
+}
 
 class BinEditorImpl: public IEditor
 {