From 046f510e191b6fa062cbea65e04c8e29bd65892b Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Mon, 19 Jan 2015 11:35:19 +0100 Subject: [PATCH] CppTools: Fix revision check in CppLocatorData Bug was exhibited by running e.g. ./qtcreator -test CppEditor,test_quickfix_MoveFuncDefOutside_FreeFuncToCppNS \ -test CppTools,test_cpplocatorfilters_CppLocatorFilter:CppFunctionsFilter-WithNamespacePrefix Change-Id: I57d96a8f7bf0aea6eb11cb68d1b981808533ce41 Reviewed-by: Christian Stenger --- src/plugins/cpptools/cpplocatordata.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/plugins/cpptools/cpplocatordata.cpp b/src/plugins/cpptools/cpplocatordata.cpp index 4d87c2f5a58..8d5bcac72e5 100644 --- a/src/plugins/cpptools/cpplocatordata.cpp +++ b/src/plugins/cpptools/cpplocatordata.cpp @@ -54,8 +54,7 @@ void CppLocatorData::onDocumentUpdated(const CPlusPlus::Document::Ptr &document) int i = 0, ei = m_pendingDocuments.size(); for (; i < ei; ++i) { const CPlusPlus::Document::Ptr &doc = m_pendingDocuments.at(i); - if (doc->fileName() == document->fileName() - && doc->revision() < document->revision()) { + if (doc->fileName() == document->fileName() && doc->revision() <= document->revision()) { m_pendingDocuments[i] = document; break; }