feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Qml Designer Theming: Fix background color

Browse Source 
The background color for light theme is too dark. Instead of trying hard
to deduct that color mathematically, let's add a theme role for it.

Change-Id: I6a49d43e7e11c87427242819c67988b05b87518b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Alessandro Portale
2016-08-04 14:03:14 +02:00
parent 423255e052
commit 04c136b92f
7 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
share/qtcreator/themes/dark.creatortheme
View File

@@ -200,6 +200,7 @@ PaletteWindowTextDisabled=textDisabled
PaletteBaseDisabled=backgroundColorDisabled PaletteBaseDisabled=backgroundColorDisabled
PaletteTextDisabled=textDisabled PaletteTextDisabled=textDisabled
QmlDesigner_BackgroundColor=ff3c3e40
QmlDesigner_HighlightColor=ff46a2da QmlDesigner_HighlightColor=ff46a2da
[Flags] [Flags]

1
share/qtcreator/themes/default.creatortheme
View File

@@ -171,6 +171,7 @@ ProjectExplorer_TaskWarn_TextMarkColor=ffffa500
ClangCodeModel_Error_TextMarkColor=ffff882f ClangCodeModel_Error_TextMarkColor=ffff882f
ClangCodeModel_Warning_TextMarkColor=ffc6c132 ClangCodeModel_Warning_TextMarkColor=ffc6c132
QmlDesigner_BackgroundColor=ff4c4e50
QmlDesigner_HighlightColor=ff46a2da QmlDesigner_HighlightColor=ff46a2da
[Flags] [Flags]

1
share/qtcreator/themes/flat-dark.creatortheme
View File

@@ -185,6 +185,7 @@ ProjectExplorer_TaskWarn_TextMarkColor=ffffff40
ClangCodeModel_Error_TextMarkColor=ffff882f ClangCodeModel_Error_TextMarkColor=ffff882f
ClangCodeModel_Warning_TextMarkColor=ffceff40 ClangCodeModel_Warning_TextMarkColor=ffceff40
QmlDesigner_BackgroundColor=ff4c4e50
QmlDesigner_HighlightColor=ff3f91c4 QmlDesigner_HighlightColor=ff3f91c4
PaletteWindow=normalBackground PaletteWindow=normalBackground

1
share/qtcreator/themes/flat-light.creatortheme
View File

@@ -182,6 +182,7 @@ ProjectExplorer_TaskWarn_TextMarkColor=ffffa500
ClangCodeModel_Error_TextMarkColor=ffff882f ClangCodeModel_Error_TextMarkColor=ffff882f
ClangCodeModel_Warning_TextMarkColor=ffc6c132 ClangCodeModel_Warning_TextMarkColor=ffc6c132
QmlDesigner_BackgroundColor=fff8f8f8
QmlDesigner_HighlightColor=ff46a2da QmlDesigner_HighlightColor=ff46a2da
[Flags] [Flags]

1
share/qtcreator/themes/flat.creatortheme
View File

@@ -181,6 +181,7 @@ ProjectExplorer_TaskWarn_TextMarkColor=ffffa500
ClangCodeModel_Error_TextMarkColor=ffff882f ClangCodeModel_Error_TextMarkColor=ffff882f
ClangCodeModel_Warning_TextMarkColor=ffc6c132 ClangCodeModel_Warning_TextMarkColor=ffc6c132
QmlDesigner_BackgroundColor=ff4c4e50
QmlDesigner_HighlightColor=ff46a2da QmlDesigner_HighlightColor=ff46a2da
[Flags] [Flags]

1
src/libs/utils/theme/theme.h
View File

@@ -282,6 +282,7 @@ public:
ClangCodeModel_Warning_TextMarkColor, ClangCodeModel_Warning_TextMarkColor,
/* QmlDesigner */ /* QmlDesigner */
QmlDesigner_BackgroundColor,
QmlDesigner_HighlightColor QmlDesigner_HighlightColor
}; };

10
src/plugins/qmldesigner/components/componentcore/theming.cpp
View File

@@ -33,13 +33,6 @@
namespace QmlDesigner { namespace QmlDesigner {
QColor midtone(const QColor &a, const QColor &b)
{
QColor alphaB = b;
alphaB.setAlpha(128);
return Utils::StyleHelper::alphaBlendedColors(a ,alphaB);
}
void Theming::insertTheme(QQmlPropertyMap *map) void Theming::insertTheme(QQmlPropertyMap *map)
{ {
const QVariantHash creatorTheme = Utils::creatorTheme()->values(); const QVariantHash creatorTheme = Utils::creatorTheme()->values();
@@ -47,6 +40,7 @@ void Theming::insertTheme(QQmlPropertyMap *map)
map->insert(it.key(), it.value()); map->insert(it.key(), it.value());
/* Define QmlDesigner colors and remove alpha channels */ /* Define QmlDesigner colors and remove alpha channels */
const QColor backgroundColor = Utils::creatorTheme()->color(Utils::Theme::QmlDesigner_BackgroundColor);
const QColor panelStatusBarBackgroundColor = Utils::creatorTheme()->color(Utils::Theme::PanelStatusBarBackgroundColor); const QColor panelStatusBarBackgroundColor = Utils::creatorTheme()->color(Utils::Theme::PanelStatusBarBackgroundColor);
const QColor fancyToolButtonSelectedColor = Utils::creatorTheme()->color(Utils::Theme::FancyToolButtonSelectedColor); const QColor fancyToolButtonSelectedColor = Utils::creatorTheme()->color(Utils::Theme::FancyToolButtonSelectedColor);
const QColor darkerBackground = Utils::StyleHelper::alphaBlendedColors(panelStatusBarBackgroundColor, fancyToolButtonSelectedColor); const QColor darkerBackground = Utils::StyleHelper::alphaBlendedColors(panelStatusBarBackgroundColor, fancyToolButtonSelectedColor);
@@ -65,7 +59,7 @@ void Theming::insertTheme(QQmlPropertyMap *map)
} }
map->insert("QmlDesignerBackgroundColorDarker", darkerBackground); map->insert("QmlDesignerBackgroundColorDarker", darkerBackground);
map->insert("QmlDesignerBackgroundColorDarkAlternate", midtone(panelStatusBarBackgroundColor, buttonColor)); map->insert("QmlDesignerBackgroundColorDarkAlternate", backgroundColor);
map->insert("QmlDesignerTabLight", tabLight); map->insert("QmlDesignerTabLight", tabLight);
map->insert("QmlDesignerTabDark", tabDark); map->insert("QmlDesignerTabDark", tabDark);
map->insert("QmlDesignerButtonColor", buttonColor); map->insert("QmlDesignerButtonColor", buttonColor);