feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Subversion: Move plugin pimpl to .cpp

Browse Source 
Change-Id: I457747564bbe0bc71d009d08b27e2375dd4c073f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2020-01-30 17:02:30 +01:00
parent 1023a1d474
commit 04e45d1bd9
6 changed files with 175 additions and 186 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/plugins/subversion/subversionclient.cpp
View File

@@ -172,7 +172,12 @@ class SubversionDiffEditorController : public VcsBaseDiffEditorController
Q_OBJECT
public:
SubversionDiffEditorController(IDocument *document,
const QString &workingDirectory);
VcsBaseClient *client,
const QString &workingDirectory)
: VcsBaseDiffEditorController(document, client, workingDirectory)
{
forceContextLineCount(3); // SVN cannot change that when using internal diff
}
void setFilesList(const QStringList &filesList);
void setChangeNumber(int changeNumber);
@@ -186,19 +191,11 @@ private:
void requestDiff();
enum State { Idle, GettingDescription, GettingDiff };
State m_state;
State m_state = Idle;
QStringList m_filesList;
int m_changeNumber = 0;
};
SubversionDiffEditorController::SubversionDiffEditorController(
IDocument *document,
const QString &workingDirectory)
: VcsBaseDiffEditorController(document, SubversionPluginPrivate::instance()->client(), workingDirectory)
, m_state(Idle)
{
forceContextLineCount(3); // SVN cannot change that when using internal diff
}
void SubversionDiffEditorController::setFilesList(const QStringList &filesList)
{
@@ -271,13 +268,13 @@ void SubversionDiffEditorController::processCommandOutput(const QString &output)
SubversionDiffEditorController *SubversionClient::findOrCreateDiffEditor(const QString &documentId,
const QString &source,
const QString &title,
const QString &workingDirectory) const
const QString &workingDirectory)
{
IDocument *document = DiffEditorController::findOrCreateDocument(documentId, title);
auto controller = qobject_cast<SubversionDiffEditorController *>(
DiffEditorController::controller(document));
if (!controller)
controller = new SubversionDiffEditorController(document, workingDirectory);
controller = new SubversionDiffEditorController(document, this, workingDirectory);
VcsBase::setSource(document, source);
EditorManager::activateEditorForDocument(document);
return controller;