From 0533636758b90929aba556c950579ac9ec4ce549 Mon Sep 17 00:00:00 2001
From: Marco Bubke <marco.bubke@qt.io>
Date: Thu, 20 Jul 2023 11:15:06 +0200
Subject: [PATCH] Utils: Skip one temporary string in constructor

Instead of creating a temporary string we simply call append directly.

Change-Id: I75ffd80a4359a19892b196f5d1ddb50b90c5a2cd
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
---
 src/libs/utils/smallstring.h | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/src/libs/utils/smallstring.h b/src/libs/utils/smallstring.h
index b3d4434a9d0..30d0dd746f8 100644
--- a/src/libs/utils/smallstring.h
+++ b/src/libs/utils/smallstring.h
@@ -108,13 +108,9 @@ public:
         static_assert(!std::is_array<Type>::value, "Input type is array and not char pointer!");
     }
 
-    BasicSmallString(const QString &qString)
-        : BasicSmallString(BasicSmallString::fromQString(qString))
-    {}
+    BasicSmallString(const QString &qString) { append(qString); }
 
-    BasicSmallString(const QStringView qStringView)
-        : BasicSmallString(BasicSmallString::fromQStringView(qStringView))
-    {}
+    BasicSmallString(const QStringView qStringView) { append(qStringView); }
 
     BasicSmallString(const QByteArray &qByteArray)
         : BasicSmallString(qByteArray.constData(), qByteArray.size())
@@ -127,9 +123,7 @@ public:
     {
     }
 
-    BasicSmallString(const std::wstring &wstring)
-        : BasicSmallString(BasicSmallString::fromQStringView(wstring))
-    {}
+    BasicSmallString(const std::wstring &wstring) { append(wstring); }
 
     template<typename BeginIterator,
              typename EndIterator,