feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Make import of build directories using Qt 6 work

Browse Source 
Make import of build directories using Qt 6 work. This assumes that
Qt 6 will use the same layout as Qt 5 and that there is qmake (which
is assumed everywhere in Creator right now).

Change-Id: I37194b186127befb3df32ebacf86c032c71ef18a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
Tobias Hunger
2020-06-17 10:45:09 +02:00
parent faf9c883f2
commit 054f5617f8
1 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/plugins/cmakeprojectmanager/cmakeprojectimporter.cpp
View File

@@ -122,11 +122,18 @@ static Utils::FilePath qmakeFromCMakeCache(const CMakeConfig &config)
return qmake; return qmake;
// Check Qt5 settings: oh, the horror! // Check Qt5 settings: oh, the horror!
const Utils::FilePath qtCMakeDir const Utils::FilePath qtCMakeDir = [config]() {
= Utils::FilePath::fromUtf8(CMakeConfigItem::valueOf(QByteArray("Qt5Core_DIR"), config)); Utils::FilePath tmp = Utils::FilePath::fromUtf8(
qCDebug(cmInputLog()) << "Qt5Core_DIR=" << qtCMakeDir.toUserOutput(); CMakeConfigItem::valueOf(QByteArray("Qt5Core_DIR"), config));
if (tmp.isEmpty()) {
tmp = Utils::FilePath::fromUtf8(
CMakeConfigItem::valueOf(QByteArray("Qt6Core_DIR"), config));
}
return tmp;
}();
qCDebug(cmInputLog()) << "QtXCore_DIR=" << qtCMakeDir.toUserOutput();
const Utils::FilePath canQtCMakeDir = Utils::FilePath::fromString(qtCMakeDir.toFileInfo().canonicalFilePath()); const Utils::FilePath canQtCMakeDir = Utils::FilePath::fromString(qtCMakeDir.toFileInfo().canonicalFilePath());
qCInfo(cmInputLog()) << "Qt5Core_DIR (canonical)=" << canQtCMakeDir.toUserOutput(); qCInfo(cmInputLog()) << "QtXCore_DIR (canonical)=" << canQtCMakeDir.toUserOutput();
if (qtCMakeDir.isEmpty()) if (qtCMakeDir.isEmpty())
return Utils::FilePath(); return Utils::FilePath();
const Utils::FilePath baseQtDir = canQtCMakeDir.parentDir().parentDir().parentDir(); // Up 3 levels... const Utils::FilePath baseQtDir = canQtCMakeDir.parentDir().parentDir().parentDir(); // Up 3 levels...
@@ -147,8 +154,11 @@ static Utils::FilePath qmakeFromCMakeCache(const CMakeConfig &config)
// endif() // endif()
QFile extras(qtCMakeDir.toString() + "/Qt5CoreConfigExtras.cmake"); QFile extras(qtCMakeDir.toString() + "/Qt5CoreConfigExtras.cmake");
if (!extras.open(QIODevice::ReadOnly)) if (!extras.open(QIODevice::ReadOnly)) {
return Utils::FilePath(); extras.setFileName(qtCMakeDir.toString() + "/Qt6CoreConfigExtras.cmake");
if (!extras.open(QIODevice::ReadOnly))
return Utils::FilePath();
}
QByteArray data; QByteArray data;
bool inQmakeSection = false; bool inQmakeSection = false;
@@ -172,7 +182,8 @@ static Utils::FilePath qmakeFromCMakeCache(const CMakeConfig &config)
line.replace(")", " ) "); line.replace(")", " ) ");
line = line.simplified(); line = line.simplified();
if (line == "if ( NOT TARGET Qt5::qmake )") if (line == "if ( NOT TARGET Qt5::qmake )"
|| line == "if ( NOT TARGET Qt6::qmake )")
inQmakeSection = true; inQmakeSection = true;
if (!inQmakeSection) if (!inQmakeSection)