feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix some Krazy warnings about non-const ref iterator.

Browse Source 
Change-Id: I1c78f5f5a7174002cd25bea109d5fe795530cdb5
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This commit is contained in:
Friedemann Kleint
2013-03-11 17:23:55 +01:00
parent 28413a8153
commit 056e8aa4c2
16 changed files with 22 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/utils/environment.cpp
View File

@@ -258,7 +258,7 @@ QString Environment::searchInPath(const QString &executable,
}
}
foreach (QString dir, additionalDirs) {
foreach (const QString &dir, additionalDirs) {
QString tmp = searchInDirectory(execs, dir);
if (!tmp.isEmpty())
return tmp;

2
src/libs/utils/json.cpp
View File

@@ -87,7 +87,7 @@ JsonValue *JsonValue::build(const QVariant &variant)
case QVariant::List: {
JsonArrayValue *newValue = new JsonArrayValue;
foreach (const QVariant element, variant.toList())
foreach (const QVariant &element, variant.toList())
newValue->addElement(build(element));
return newValue;
}

2
src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp
View File

@@ -74,7 +74,7 @@ QList<Locator::FilterEntry> CMakeLocatorFilter::matchesFor(QFutureInterface<Loca
foreach (ProjectExplorer::Project *p, projects) {
CMakeProject *cmakeProject = qobject_cast<CMakeProject *>(p);
if (cmakeProject) {
foreach (CMakeBuildTarget ct, cmakeProject->buildTargets()) {
foreach (const CMakeBuildTarget &ct, cmakeProject->buildTargets()) {
if (ct.title.contains(entry)) {
Locator::FilterEntry entry(this, ct.title, cmakeProject->document()->fileName());
entry.extraInfo = FileUtils::shortNativePath(

4
src/plugins/debugger/gdb/gdbengine.cpp
View File

@@ -2675,7 +2675,7 @@ void GdbEngine::handleBreakInsert1(const GdbResponse &response)
BreakpointResponseId rid(nr);
if (!isHiddenBreakpoint(rid)) {
BreakpointResponse br = handler->response(id);
foreach (const GdbMi bkpt, response.data.children()) {
foreach (const GdbMi &bkpt, response.data.children()) {
nr = bkpt.findChild("number").data();
rid = BreakpointResponseId(nr);
QTC_ASSERT(rid.isValid(), continue);
@@ -3518,7 +3518,7 @@ void GdbEngine::handleModulesList(const GdbResponse &response)
void GdbEngine::examineModules()
{
ModulesHandler *handler = modulesHandler();
foreach (Module module, handler->modules()) {
foreach (const Module &module, handler->modules()) {
if (module.elfData.symbolsType == UnknownSymbols)
handler->updateModule(module);
}

2
src/plugins/debugger/qml/qmlinspectoragent.cpp
View File

@@ -467,7 +467,7 @@ void QmlInspectorAgent::onResult(quint32 queryId, const QVariant &value,
m_objectTreeQueryIds.removeOne(queryId);
if (value.type() == QVariant::List) {
QVariantList objList = value.toList();
foreach (QVariant var, objList) {
foreach (const QVariant &var, objList) {
// TODO: check which among the list is the actual
// object that needs to be selected.
verifyAndInsertObjectInTree(qvariant_cast<ObjectReference>(var));

2
src/plugins/qmldesigner/components/componentcore/modelnodecontextmenu_helper.cpp
View File

@@ -77,7 +77,7 @@ static inline void getProperties(const ModelNode node, QHash<PropertyName, QVari
static inline void applyProperties(ModelNode &node, const QHash<PropertyName, QVariant> &propertyHash)
{
QHash<PropertyName, QVariant> auxiliaryData = node.auxiliaryData();
foreach (const PropertyName propertyName, auxiliaryData.keys()) {
foreach (const PropertyName &propertyName, auxiliaryData.keys()) {
node.setAuxiliaryData(propertyName, QVariant());
}

2
src/plugins/qmldesigner/designercore/metainfo/subcomponentmanager.cpp
View File

@@ -212,7 +212,7 @@ void SubComponentManager::parseDirectories()
if (dirInfo.exists() && dirInfo.isDir())
parseDirectory(dirInfo.canonicalFilePath());
foreach (const QString subDir, QDir(QFileInfo(file).path()).entryList(QDir::Dirs | QDir::NoDot | QDir::NoDotDot)) {
foreach (const QString &subDir, QDir(QFileInfo(file).path()).entryList(QDir::Dirs | QDir::NoDot | QDir::NoDotDot)) {
parseDirectory(dirInfo.canonicalFilePath() + "/" + subDir, true, subDir.toUtf8());
}
}

2
src/plugins/qmldesigner/designercore/model/rewriterview.cpp
View File

@@ -717,7 +717,7 @@ QString RewriterView::pathForImport(const Import &import)
QmlJS::ImportInfo importInfo;
foreach (QmlJS::Import qmljsImport, imports->all()) {
foreach (const QmlJS::Import &qmljsImport, imports->all()) {
if (qmljsImport.info.name() == importStr)
importInfo = qmljsImport.info;
}

2
src/plugins/qmljseditor/qmljscompletionassist.cpp
View File

@@ -668,7 +668,7 @@ IAssistProposal *QmlJSCompletionAssistProcessor::perform(const IAssistInterface
QStringList nCompletions;
QString prefix(libVersion.left(toSkip));
nCompletions.reserve(completions.size());
foreach (QString completion, completions)
foreach (const QString &completion, completions)
if (completion.startsWith(prefix))
nCompletions.append(completion.right(completion.size()-toSkip));
completions = nCompletions;

2
src/plugins/qnx/blackberryconfiguration.cpp
View File

@@ -135,7 +135,7 @@ void BlackBerryConfiguration::loadCertificates()
settings->beginGroup(SettingsGroup);
settings->beginGroup(CertificateGroup);
foreach (QString certificateId, settings->childGroups()) {
foreach (const QString &certificateId, settings->childGroups()) {
settings->beginGroup(certificateId);
BlackBerryCertificate *cert =

5
src/plugins/texteditor/refactoringchanges.cpp
View File

@@ -382,8 +382,9 @@ void RefactoringFile::indentOrReindent(void (RefactoringChangesData::*mf)(const
const BaseTextEditorWidget *) const,
const QList<QPair<QTextCursor, QTextCursor> > &ranges)
{
QPair<QTextCursor, QTextCursor> p;
foreach (p, ranges) {
typedef QPair<QTextCursor, QTextCursor> CursorPair;
foreach (const CursorPair &p, ranges) {
QTextCursor selection(p.first.document());
selection.setPosition(p.first.position());
selection.setPosition(p.second.position(), QTextCursor::KeepAnchor);

7
src/tools/cplusplus-update-frontend/cplusplus-update-frontend.cpp
View File

@@ -1562,6 +1562,8 @@ void generateASTFwd_h(const Snapshot &snapshot, const QDir &cplusplusDir, const
void generateASTPatternBuilder_h(const QDir &cplusplusDir)
{
typedef QPair<QString, QString> StringPair;
QFileInfo fileInfo(cplusplusDir, QLatin1String("ASTPatternBuilder.h"));
QFile file(fileInfo.absoluteFilePath());
if (! file.open(QFile::WriteOnly))
@@ -1619,7 +1621,7 @@ void generateASTPatternBuilder_h(const QDir &cplusplusDir)
out
<< " " << className << " *" << methodName << "(";
QList<QPair<QString, QString> > args;
QList<StringPair> args;
bool first = true;
for (unsigned index = 0; index < klass->memberCount(); ++index) {
@@ -1652,8 +1654,7 @@ void generateASTPatternBuilder_h(const QDir &cplusplusDir)
<< " " << className << " *__ast = new (&pool) " << className << ';' << endl;
QPair<QString, QString> p;
foreach (p, args) {
foreach (const StringPair &p, args) {
out << " __ast->" << p.second << " = " << p.second << ';' << endl;
}

2
src/tools/sdktool/addkitoperation.cpp
View File

@@ -355,7 +355,7 @@ QVariantMap AddKitOperation::addKit(const QVariantMap &map,
// Sanity check: Make sure displayName is unique.
QStringList nameKeys = FindKeyOperation::findKey(map, QLatin1String(DISPLAYNAME));
QStringList nameList;
foreach (const QString nameKey, nameKeys)
foreach (const QString &nameKey, nameKeys)
nameList << GetOperation::get(map, nameKey).toString();
const QString uniqueName = makeUnique(displayName, nameList);

2
src/tools/sdktool/addqtoperation.cpp
View File

@@ -285,7 +285,7 @@ QVariantMap AddQtOperation::addQt(const QVariantMap &map,
// Sanity check: Make sure displayName is unique.
QStringList nameKeys = FindKeyOperation::findKey(map, QLatin1String(DISPLAYNAME));
QStringList nameList;
foreach (const QString nameKey, nameKeys)
foreach (const QString &nameKey, nameKeys)
nameList << GetOperation::get(map, nameKey).toString();
const QString uniqueName = makeUnique(displayName, nameList);

2
src/tools/sdktool/addtoolchainoperation.cpp
View File

@@ -249,7 +249,7 @@ QVariantMap AddToolChainOperation::addToolChain(const QVariantMap &map,
// Sanity check: Make sure displayName is unique.
QStringList nameKeys = FindKeyOperation::findKey(map, QLatin1String(DISPLAYNAME));
QStringList nameList;
foreach (const QString nameKey, nameKeys)
foreach (const QString &nameKey, nameKeys)
nameList << GetOperation::get(map, nameKey).toString();
const QString uniqueName = makeUnique(displayName, nameList);

2
src/tools/sdktool/findkeyoperation.cpp
View File

@@ -74,7 +74,7 @@ int FindKeyOperation::execute() const
foreach (const QString &k, m_keys) {
const QStringList result = findKey(map, k);
foreach (const QString r, result)
foreach (const QString &r, result)
std::cout << qPrintable(r) << std::endl;
}