feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Environment: Move isEmpty() test to beginning

Browse Source 
No reason to initialize a QFileInfo for an empty string

Change-Id: I537fc98e1a5dd2283db9e5e60717eb8873c02b13
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This commit is contained in:
Orgad Shaneh
2013-05-17 08:20:15 +03:00
committed by Orgad Shaneh
parent fc6ec40f2f
commit 05b3903b6a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libs/utils/environment.cpp
View File

@@ -236,12 +236,12 @@ QString Environment::searchInDirectory(const QStringList &execs, QString directo
QString Environment::searchInPath(const QString &executable,
const QStringList &additionalDirs) const
{
QString exec = QDir::cleanPath(expandVariables(executable));
QFileInfo fi(exec);
if (executable.isEmpty())
return QString();
QString exec = QDir::cleanPath(expandVariables(executable));
QFileInfo fi(exec);
QStringList execs(exec);
if (HostOsInfo::isWindowsHost()) {
// Check all the executable extensions on windows: