From 05eec13ade20b4b6ddcf8ef3bbf5addf59bd6f17 Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Fri, 2 Sep 2022 16:11:42 +0200
Subject: [PATCH] StudioWelcome: Avoid using sender()

Change-Id: I3d075867c9114f52ead920b3120904fc79bba775
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
---
 src/plugins/studiowelcome/wizardhandler.cpp | 14 ++++----------
 src/plugins/studiowelcome/wizardhandler.h   |  1 -
 2 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/src/plugins/studiowelcome/wizardhandler.cpp b/src/plugins/studiowelcome/wizardhandler.cpp
index 91b0091b737..c8dc79a79c1 100644
--- a/src/plugins/studiowelcome/wizardhandler.cpp
+++ b/src/plugins/studiowelcome/wizardhandler.cpp
@@ -87,8 +87,10 @@ void WizardHandler::initializeProjectPage(QWizardPage *page)
     auto *jpp = dynamic_cast<ProjectExplorer::JsonProjectPage *>(page);
     QTC_ASSERT(jpp, return);
 
-    QObject::connect(jpp, &ProjectExplorer::JsonProjectPage::statusMessageChanged, this, &WizardHandler::statusMessageChanged);
-    QObject::connect(jpp, &ProjectExplorer::JsonProjectPage::completeChanged, this, &WizardHandler::onProjectIntroCompleteChanged);
+    QObject::connect(jpp, &ProjectExplorer::JsonProjectPage::statusMessageChanged,
+                     this, &WizardHandler::statusMessageChanged);
+    QObject::connect(jpp, &ProjectExplorer::JsonProjectPage::completeChanged,
+                     this, [this, jpp] { emit projectCanBeCreated(jpp->isComplete()); });
 }
 
 void WizardHandler::initializeFieldsPage(QWizardPage *page)
@@ -100,14 +102,6 @@ void WizardHandler::initializeFieldsPage(QWizardPage *page)
     fieldsPage->initializePage();
 }
 
-void WizardHandler::onProjectIntroCompleteChanged()
-{
-    auto *page = dynamic_cast<ProjectExplorer::JsonProjectPage *>(QObject::sender());
-    QTC_ASSERT(page, return);
-
-    emit projectCanBeCreated(page->isComplete());
-}
-
 QStandardItemModel *WizardHandler::getScreenFactorModel(ProjectExplorer::JsonFieldPage *page)
 {
     auto *field = page->jsonField("ScreenFactor");
diff --git a/src/plugins/studiowelcome/wizardhandler.h b/src/plugins/studiowelcome/wizardhandler.h
index 8cdf00f832e..fb370f744a0 100644
--- a/src/plugins/studiowelcome/wizardhandler.h
+++ b/src/plugins/studiowelcome/wizardhandler.h
@@ -71,7 +71,6 @@ private:
 
 private slots:
     void onWizardResetting();
-    void onProjectIntroCompleteChanged();
 
 private:
     Utils::Wizard *m_wizard = nullptr;