feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Autotools: Modernize

Browse Source 
* Use pragma once
* Make sure overrides are everywhere
* Clean up code here and there
* Remove useless code from initializer lists

Change-Id: I9c285a803ea36cb32d14b3335757fd4b57f27d02
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Tobias Hunger
2016-02-03 17:21:12 +01:00
parent 9b3016c2e4
commit 063b9775a9
26 changed files with 83 additions and 198 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/autotoolsprojectmanager/autoreconfstep.cpp
View File

@@ -52,10 +52,8 @@ const char AUTORECONF_ADDITIONAL_ARGUMENTS_KEY[] = "AutotoolsProjectManager.Auto
////////////////////////////////
// AutoreconfStepFactory class
////////////////////////////////
AutoreconfStepFactory::AutoreconfStepFactory(QObject *parent) :
IBuildStepFactory(parent)
{
}
AutoreconfStepFactory::AutoreconfStepFactory(QObject *parent) : IBuildStepFactory(parent)
{ }
QList<Core::Id> AutoreconfStepFactory::availableCreationIds(BuildStepList *parent) const
{
@@ -122,14 +120,12 @@ bool AutoreconfStepFactory::canHandle(BuildStepList *parent) const
// AutoreconfStep class
/////////////////////////
AutoreconfStep::AutoreconfStep(BuildStepList *bsl) :
AbstractProcessStep(bsl, Core::Id(AUTORECONF_STEP_ID)),
m_runAutoreconf(false)
AbstractProcessStep(bsl, Core::Id(AUTORECONF_STEP_ID))
{
ctor();
}
AutoreconfStep::AutoreconfStep(BuildStepList *bsl, Core::Id id) :
AbstractProcessStep(bsl, id)
AutoreconfStep::AutoreconfStep(BuildStepList *bsl, Core::Id id) : AbstractProcessStep(bsl, id)
{
ctor();
}
@@ -229,15 +225,13 @@ bool AutoreconfStep::fromMap(const QVariantMap &map)
//////////////////////////////////////
AutoreconfStepConfigWidget::AutoreconfStepConfigWidget(AutoreconfStep *autoreconfStep) :
m_autoreconfStep(autoreconfStep),
m_summaryText(),
m_additionalArguments(0)
m_additionalArguments(new QLineEdit(this))
{
QFormLayout *fl = new QFormLayout(this);
fl->setMargin(0);
fl->setFieldGrowthPolicy(QFormLayout::ExpandingFieldsGrow);
setLayout(fl);
m_additionalArguments = new QLineEdit(this);
fl->addRow(tr("Arguments:"), m_additionalArguments);
m_additionalArguments->setText(m_autoreconfStep->additionalArguments());