feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Fix (Q)Process::interrupt

Browse Source 
Since switching to a QProcess based implementation a different
code path is used to interrupt processes (QProcessImpl::sendControlSignal, instead of ProcessLauncherImpl::sendControlSignal).

The QProcess path still used outdated ProcessHelper::interruptProcess.

This patch removes the old path and replaces it with the correct
"ProcessHelper::interruptPid" for QProcess based processes.

This also fixes GdbEngine::interruptInferior2 which could not interrupt
processes during "Attach to running server"

Change-Id: I9e1917100acf89c07cab0d9c687e57bb555d9d83
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Marcus Tillmanns
2024-01-15 14:08:05 +01:00
parent 2be9a658ad
commit 06658d981c
3 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/utils/process.cpp
View File

@@ -486,7 +486,7 @@ private:
m_process->kill();
break;
case ControlSignal::Interrupt:
ProcessHelper::interruptProcess(m_process);
ProcessHelper::interruptPid(m_process->processId());
break;
case ControlSignal::KickOff:
QTC_CHECK(false);