From 068304214155b2b5d57015862612cbb4292a6b64 Mon Sep 17 00:00:00 2001 From: Robert Loehning Date: Fri, 15 Sep 2017 17:36:26 +0200 Subject: [PATCH] ClearCase: Don't try reading when file cannot be opened Change-Id: Id403f9ed58fb624aef7f6d54607e19a5dd057fd5 Reviewed-by: Orgad Shaneh Reviewed-by: Robert Loehning --- src/plugins/clearcase/clearcaseplugin.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/plugins/clearcase/clearcaseplugin.cpp b/src/plugins/clearcase/clearcaseplugin.cpp index 03f570d9814..9eea4a6cfb0 100644 --- a/src/plugins/clearcase/clearcaseplugin.cpp +++ b/src/plugins/clearcase/clearcaseplugin.cpp @@ -1668,10 +1668,12 @@ bool ClearCasePlugin::vcsCheckIn(const QString &messageFile, const QStringList & replaceActivity &= (activity != QLatin1String(Constants::KEEP_ACTIVITY)); if (replaceActivity && !vcsSetActivity(m_checkInView, title, activity)) return false; + QString message; QFile msgFile(messageFile); - msgFile.open(QFile::ReadOnly | QFile::Text); - QString message = QString::fromLocal8Bit(msgFile.readAll().trimmed().constData()); - msgFile.close(); + if (msgFile.open(QFile::ReadOnly | QFile::Text)) { + message = QString::fromLocal8Bit(msgFile.readAll().trimmed()); + msgFile.close(); + } QStringList args; args << QLatin1String("checkin"); if (message.isEmpty())