ProjectExplorer: Simplify LocalEnvspect's BaseEnvironmentModifier

The run configuration is known at setup time, and fixed.

Change-Id: Iad7837bf39fb5eeed49bd71b7f14b9692014ea9d
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

src/plugins/qbsprojectmanager/qbsrunconfiguration.cpp

@@ -53,9 +53,7 @@ QbsRunConfiguration::QbsRunConfiguration(Target *target, Core::Id id)
     : RunConfiguration(target, id)
 {
     auto envAspect = addAspect<LocalEnvironmentAspect>(
-            [](RunConfiguration *rc, Environment &env) {
-                static_cast<QbsRunConfiguration *>(rc)->addToBaseEnvironment(env);
-            });
+            [this](Environment &env) { addToBaseEnvironment(env); });
 
     addAspect<ExecutableAspect>();
     addAspect<ArgumentsAspect>();