forked from qt-creator/qt-creator
FutureSynchronizer: Change the default value of cancelOnWait to true
The "false" default wasn't really useful. This changes the default value to the following usages: 1. AndroidDeployQtStep Introduced in91f136ef3aThe synchronizer was used to cancel the running tasks inside the doCancel(), so the similar behavior should be expected when destructing the AndroidDeployQtStep. 2. GitClient Introduced inf3106ebafeIs used only inside the last line of GitSubmitEditor::updateFileModel(). The running function (CommitDataFetchResult::fetch) doesn't take QPromise<>, so it can't detect if the future was canceled or not. In this case this change is no-op. 3. ExtraCompiler Introduced inc99ce1f455The intention was to make it cancellable and finish early on cancel. 4. PluginManager global future synchronizer Introduced in72bddf9f51The intention was to make it cancellable and finish early on cancel. The relevant places in code are marked explicitly for points: 1, 2 and 3. Change-Id: I1a52deb8d1f81d355950c8772bbaa6d0a202fd7e Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
@@ -133,6 +133,7 @@ private:
|
||||
Environment m_environment;
|
||||
AndroidDeviceInfo m_deviceInfo;
|
||||
|
||||
// The synchronizer has cancelOnWait set to true by default.
|
||||
FutureSynchronizer m_synchronizer;
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user