feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix potential crash when closing settings dialog.

Browse Source 
We accessed the m_applied member after the dialog already was deleted.

Task-number: QTCREATORBUG-2844
Reviewed-by: Friedemann Kleint
This commit is contained in:
con
2010-10-21 14:10:31 +02:00
parent a015eb53af
commit 0765a9819d
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/coreplugin/dialogs/settingsdialog.cpp
View File

@@ -314,7 +314,6 @@ SettingsDialog::SettingsDialog(QWidget *parent) :
m_proxyModel, SLOT(setFilterFixedString(QString))); m_proxyModel, SLOT(setFilterFixedString(QString)));
connect(m_filterLineEdit, SIGNAL(filterChanged(QString)), this, SLOT(filter(QString))); connect(m_filterLineEdit, SIGNAL(filterChanged(QString)), this, SLOT(filter(QString)));
m_categoryList->setFocus(); m_categoryList->setFocus();
setAttribute(Qt::WA_DeleteOnClose);
} }
void SettingsDialog::showPage(const QString &categoryId, const QString &pageId) void SettingsDialog::showPage(const QString &categoryId, const QString &pageId)
@@ -522,6 +521,11 @@ bool SettingsDialog::execDialog()
if (!m_running) { if (!m_running) {
m_running = true; m_running = true;
exec(); exec();
m_running = false;
m_instance = 0;
// make sure that the current "single" instance is deleted
// we can't delete right away, since we still access the m_applied member
deleteLater();
} else { } else {
// exec dialog is called while the instance is already running // exec dialog is called while the instance is already running
// this can happen when a event triggers a code path that wants to // this can happen when a event triggers a code path that wants to