feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CustomParser: Improve strange operator != implementation

Browse Source 
Change-Id: I42c195004a9eca9f03cf34bd274f473ed87c580e
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Tobias Hunger
2013-08-08 12:56:47 +02:00
parent f1eb9c4827
commit 0796684558
2 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/projectexplorer/customparser.cpp
View File

@@ -43,18 +43,10 @@ CustomParserSettings::CustomParserSettings() :
messageCap(3) messageCap(3)
{ } { }
bool CustomParserSettings::operator !=(const CustomParserSettings &other) const bool CustomParserSettings::operator ==(const CustomParserSettings &other) const
{ {
if (errorPattern == other.errorPattern) return errorPattern == other.errorPattern && fileNameCap == other.fileNameCap
return false; && lineNumberCap == other.lineNumberCap && messageCap == other.messageCap;
if (fileNameCap == other.fileNameCap)
return false;
if (lineNumberCap == other.lineNumberCap)
return false;
if (messageCap == other.messageCap)
return false;
return true;
} }
CustomParser::CustomParser(const CustomParserSettings &settings) : CustomParser::CustomParser(const CustomParserSettings &settings) :

3
src/plugins/projectexplorer/customparser.h
View File

@@ -43,7 +43,8 @@ class CustomParserSettings
public: public:
CustomParserSettings(); CustomParserSettings();
bool operator !=(const CustomParserSettings &other) const; bool operator ==(const CustomParserSettings &other) const;
bool operator !=(const CustomParserSettings &other) const { return !operator==(other); }
QString errorPattern; QString errorPattern;
int fileNameCap; int fileNameCap;