Fix warnings

MSVC warns about pm being unused (because settings() is static)

Change-Id: I750804cc52edc71649545bc03f798a6802c87c7d
Reviewed-by: Laszlo Papp <lpapp@kde.org>
Reviewed-by: hjk <qthjk@ovi.com>

src/plugins/projectexplorer/devicesupport/devicemanager.cpp

@@ -222,8 +222,7 @@ QVariantMap DeviceManager::toMap() const
 
 QString DeviceManager::settingsFilePath(const QString &extension)
 {
-    ExtensionSystem::PluginManager *pm = ExtensionSystem::PluginManager::instance();
+    return QFileInfo(ExtensionSystem::PluginManager::settings()->fileName()).absolutePath() + extension;
-    return QFileInfo(pm->settings()->fileName()).absolutePath() + extension;
 }
 
 void DeviceManager::addDevice(const IDevice::Ptr &_device)

src/plugins/projectexplorer/devicesupport/localprocesslist.cpp

@@ -192,6 +192,8 @@ void LocalProcessList::doKillProcess(const DeviceProcess &process)
     else
         m_error.clear();
     QTimer::singleShot(0, this, SLOT(reportDelayedKillStatus()));
+#else
+    Q_UNUSED(process);
 #endif
 }
 

src/plugins/projectexplorer/profilemanager.cpp

@@ -61,8 +61,7 @@ using Utils::PersistentSettingsReader;
 
 static QString settingsFileName()
 {
-    ExtensionSystem::PluginManager *pm = ExtensionSystem::PluginManager::instance();
+    QFileInfo settingsLocation(ExtensionSystem::PluginManager::settings()->fileName());
-    QFileInfo settingsLocation(pm->settings()->fileName());
     return settingsLocation.absolutePath() + QLatin1String(PROFILE_FILENAME);
 }
 

src/plugins/projectexplorer/settingsaccessor.cpp

@@ -2624,8 +2624,7 @@ static QString maddeRoot(const QString &qmakePath)
 
 void Version11Handler::parseQtversionFile()
 {
-    ExtensionSystem::PluginManager *pm = ExtensionSystem::PluginManager::instance();
+    QFileInfo settingsLocation(ExtensionSystem::PluginManager::settings()->fileName());
-    QFileInfo settingsLocation(pm->settings()->fileName());
     QString fileName = settingsLocation.absolutePath() + QLatin1String("/qtversion.xml");
     Utils::PersistentSettingsReader reader;
     if (!reader.load(fileName)) {
@@ -2669,8 +2668,7 @@ void Version11Handler::parseQtversionFile()
 
 void Version11Handler::parseToolChainFile()
 {
-    ExtensionSystem::PluginManager *pm = ExtensionSystem::PluginManager::instance();
+    QFileInfo settingsLocation(ExtensionSystem::PluginManager::settings()->fileName());
-    QFileInfo settingsLocation(pm->settings()->fileName());
     QString fileName = settingsLocation.absolutePath() + QLatin1String("/toolChains.xml");
     Utils::PersistentSettingsReader reader;
     if (!reader.load(fileName)) {

src/plugins/projectexplorer/toolchainmanager.cpp

@@ -58,8 +58,7 @@ using Utils::PersistentSettingsReader;
 
 static QString settingsFileName(const QString &path)
 {
-    ExtensionSystem::PluginManager *pm = ExtensionSystem::PluginManager::instance();
+    QFileInfo settingsLocation(ExtensionSystem::PluginManager::settings()->fileName());
-    QFileInfo settingsLocation(pm->settings()->fileName());
     return settingsLocation.absolutePath() + path;
 }
 

src/shared/proparser/qmakeevaluator.cpp

@@ -74,7 +74,7 @@ QMakeBaseKey::QMakeBaseKey(const QString &_root, bool _hostBuild)
 
 uint qHash(const QMakeBaseKey &key)
 {
-    return qHash(key.root) ^ key.hostBuild;
+    return qHash(key.root) ^ (uint)key.hostBuild;
 }
 
 bool operator==(const QMakeBaseKey &one, const QMakeBaseKey &two)