feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Dissolve TextEditorOptionsPage intermediate hierarchy level

Browse Source 
It's effectively setting only three properties nowadays, not enough
to justify a case of reuse-by-inheritance anymore.

Change-Id: I947fbc51e76c8d908da662dd58dce91614c28e08
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2020-01-15 15:00:57 +01:00
parent ed7fb30e66
commit 07b04c2056
18 changed files with 44 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/texteditor/displaysettingspage.cpp
View File

@@ -24,8 +24,10 @@
****************************************************************************/
#include "displaysettingspage.h"
#include "displaysettings.h"
#include "marginsettings.h"
#include "texteditorconstants.h"
#include "ui_displaysettingspage.h"
#include <coreplugin/icore.h>
@@ -56,11 +58,14 @@ DisplaySettingsPage::DisplaySettingsPagePrivate::DisplaySettingsPagePrivate
DisplaySettingsPage::DisplaySettingsPage(const DisplaySettingsPageParameters &p,
QObject *parent)
: TextEditorOptionsPage(parent),
: Core::IOptionsPage(parent),
d(new DisplaySettingsPagePrivate(p))
{
setId(p.id);
setDisplayName(p.displayName);
setCategory(TextEditor::Constants::TEXT_EDITOR_SETTINGS_CATEGORY);
setDisplayCategory(QCoreApplication::translate("TextEditor", "Text Editor"));
setCategoryIconPath(TextEditor::Constants::TEXT_EDITOR_SETTINGS_CATEGORY_ICON_PATH);
}
DisplaySettingsPage::~DisplaySettingsPage()