feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Dissolve TextEditorOptionsPage intermediate hierarchy level

Browse Source 
It's effectively setting only three properties nowadays, not enough
to justify a case of reuse-by-inheritance anymore.

Change-Id: I947fbc51e76c8d908da662dd58dce91614c28e08
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2020-01-15 15:00:57 +01:00
parent ed7fb30e66
commit 07b04c2056
18 changed files with 44 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/texteditor/snippets/snippetssettingspage.cpp
View File

@@ -549,11 +549,14 @@ void SnippetsSettingsPagePrivate::decorateEditors(const TextEditor::FontSettings
// SnippetsSettingsPage
SnippetsSettingsPage::SnippetsSettingsPage(Core::Id id, QObject *parent) :
TextEditorOptionsPage(parent),
Core::IOptionsPage(parent),
d(new SnippetsSettingsPagePrivate(id))
{
setId(d->id());
setDisplayName(d->displayName());
setCategory(TextEditor::Constants::TEXT_EDITOR_SETTINGS_CATEGORY);
setDisplayCategory(QCoreApplication::translate("TextEditor", "Text Editor"));
setCategoryIconPath(TextEditor::Constants::TEXT_EDITOR_SETTINGS_CATEGORY_ICON_PATH);
}
SnippetsSettingsPage::~SnippetsSettingsPage()

4
src/plugins/texteditor/snippets/snippetssettingspage.h
View File

@@ -25,14 +25,14 @@
#pragma once
#include "../texteditoroptionspage.h"
#include <coreplugin/dialogs/ioptionspage.h>
namespace TextEditor {
namespace Internal {
class SnippetsSettingsPagePrivate;
class SnippetsSettingsPage : public TextEditorOptionsPage
class SnippetsSettingsPage : public Core::IOptionsPage
{
Q_OBJECT