From 07c8f5249f8cf850b64e9330b0d13cb48a6024c6 Mon Sep 17 00:00:00 2001
From: Henning Gruendl <henning.gruendl@qt.io>
Date: Wed, 21 Sep 2022 12:39:05 +0200
Subject: [PATCH] QmlDesigner: Fix empty when condition submit

Task-number: QDS-7729
Change-Id: Ia9ed1a911fd9ec5d6ffdcdb7ccfe0bb2ba843dc5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
---
 share/qtcreator/qmldesigner/newstateseditor/StateMenu.qml | 4 +---
 .../qmldesigner/newstateseditor/StateThumbnail.qml        | 8 +++++++-
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/share/qtcreator/qmldesigner/newstateseditor/StateMenu.qml b/share/qtcreator/qmldesigner/newstateseditor/StateMenu.qml
index 8d0bb8810c4..d26572ebde6 100644
--- a/share/qtcreator/qmldesigner/newstateseditor/StateMenu.qml
+++ b/share/qtcreator/qmldesigner/newstateseditor/StateMenu.qml
@@ -87,9 +87,7 @@ StudioControls.Menu {
     StudioControls.MenuItem {
         enabled: !root.isBaseState && root.hasWhenCondition
         text: qsTr("Reset when Condition")
-        onTriggered: {
-           statesEditorModel.resetWhenCondition(internalNodeId)
-        }
+        onTriggered: root.resetWhenCondition()
     }
 
     StudioControls.MenuSeparator {}
diff --git a/share/qtcreator/qmldesigner/newstateseditor/StateThumbnail.qml b/share/qtcreator/qmldesigner/newstateseditor/StateThumbnail.qml
index ba7950781c4..642ebd972d1 100644
--- a/share/qtcreator/qmldesigner/newstateseditor/StateThumbnail.qml
+++ b/share/qtcreator/qmldesigner/newstateseditor/StateThumbnail.qml
@@ -654,7 +654,12 @@ Item {
                         return
 
                     whenCondition.previousCondition = whenCondition.text
-                    root.whenConditionFinished()
+
+                    if (whenCondition.text !== "")
+                        root.whenConditionFinished()
+                    else
+                        statesEditorModel.resetWhenCondition(root.internalNodeId)
+
                 }
 
                 Component.onCompleted: whenCondition.previousCondition = whenCondition.text
@@ -694,6 +699,7 @@ Item {
         onExtend: root.extend()
         onRemove: root.remove()
         onToggle: root.propertyChangesVisible = !root.propertyChangesVisible
+        onResetWhenCondition: statesEditorModel.resetWhenCondition(root.internalNodeId)
         onEditAnnotation: {
             statesEditorModel.setAnnotation(root.internalNodeId)
             stateMenu.hasAnnotation = root.checkAnnotation()