feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Abi: Remove endianness from ABI

Browse Source 
The functionality is not implemented properly, remove it before
someone thinks it was.

Change-Id: I6e9c423a6b84a4a5fcf4d817e14df97fbdc901c5
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>
Reviewed-by: Tim Sander <tim@krieglstein.org>
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This commit is contained in:
Tobias Hunger
2014-07-22 16:32:57 +02:00
parent 75ff5062d6
commit 089e690108
3 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/projectexplorer/abi.cpp
View File

@@ -817,14 +817,6 @@ QList<Abi> Abi::abisOfBinary(const Utils::FileName &path)
return result; return result;
} }
ProjectExplorer::Abi::Endianness Abi::endianness() const
{
if (m_architecture == X86Architecture)
return LittleEndian;
// All other architectures are bi-endian:/
return UnknownEndian; // Todo: Add a field for endianness to the Abi struct!
}
} // namespace ProjectExplorer } // namespace ProjectExplorer
// Unit tests: // Unit tests:

7
src/plugins/projectexplorer/abi.h
View File

@@ -101,12 +101,6 @@ public:
UnknownFormat UnknownFormat
}; };
enum Endianness {
LittleEndian,
BigEndian,
UnknownEndian
};
Abi() : Abi() :
m_architecture(UnknownArchitecture), m_os(UnknownOS), m_architecture(UnknownArchitecture), m_os(UnknownOS),
m_osFlavor(UnknownFlavor), m_binaryFormat(UnknownFormat), m_wordWidth(0) m_osFlavor(UnknownFlavor), m_binaryFormat(UnknownFormat), m_wordWidth(0)
@@ -126,7 +120,6 @@ public:
bool isNull() const; bool isNull() const;
Architecture architecture() const { return m_architecture; } Architecture architecture() const { return m_architecture; }
Endianness endianness() const;
OS os() const { return m_os; } OS os() const { return m_os; }
OSFlavor osFlavor() const { return m_osFlavor; } OSFlavor osFlavor() const { return m_osFlavor; }
BinaryFormat binaryFormat() const { return m_binaryFormat; } BinaryFormat binaryFormat() const { return m_binaryFormat; }

5
src/plugins/qbsprojectmanager/defaultpropertyprovider.cpp
View File

@@ -91,11 +91,6 @@ QVariantMap DefaultPropertyProvider::properties(const ProjectExplorer::Kit *k, c
qbs::Internal::HostOsInfo::canonicalArchitecture(architecture)); qbs::Internal::HostOsInfo::canonicalArchitecture(architecture));
} }
if (targetAbi.endianness() == ProjectExplorer::Abi::BigEndian)
data.insert(QLatin1String(QBS_ENDIANNESS), QLatin1String("big"));
else if (targetAbi.endianness() == ProjectExplorer::Abi::LittleEndian)
data.insert(QLatin1String(QBS_ENDIANNESS), QLatin1String("little"));
if (targetAbi.os() == ProjectExplorer::Abi::WindowsOS) { if (targetAbi.os() == ProjectExplorer::Abi::WindowsOS) {
data.insert(QLatin1String(QBS_TARGETOS), QLatin1String("windows")); data.insert(QLatin1String(QBS_TARGETOS), QLatin1String("windows"));
data.insert(QLatin1String(QBS_TOOLCHAIN), data.insert(QLatin1String(QBS_TOOLCHAIN),