From 08a9b2a26ff509a856b202a1e7c2ff1fbd7dd7d2 Mon Sep 17 00:00:00 2001 From: Miikka Heikkinen Date: Fri, 29 Jan 2021 13:54:21 +0200 Subject: [PATCH] QmlDesigner: Fix navigator preview image for Image components If there is no source property set for a node of Image based component, fall back to component rendering to get the default image. Fixes: QDS-3669 Change-Id: I44c14c996f0b3f61c82963fb5fc79577748bd33e Reviewed-by: Mahmoud Badri --- .../qmldesigner/designercore/instances/nodeinstanceview.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp index a28c946101e..ef7c17afadd 100644 --- a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp +++ b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp @@ -1689,6 +1689,12 @@ QVariant NodeInstanceView::previewImageDataForImageNode(const ModelNode &modelNo } } } else { + if (imageSource.isEmpty() && modelNode.isComponent()) { + // Image component has no custom source set, so fall back to component rendering to get + // the default component image. + return previewImageDataForGenericNode(modelNode, {}); + } + QFileInfo imageFi(imageSource); if (imageFi.isRelative()) imageSource = QFileInfo(modelNode.model()->fileUrl().toLocalFile()).dir().absoluteFilePath(imageSource);