feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Filter out invalid diagnostic ranges

Browse Source 
Apparently libclang might return invalid ranges.

Now we discard the invalid ranges. Since there is a diagnostic location
(in addition to ranges) the editor will still display an indication for
the user.

Task-number: QTCREATORBUG-15272
Change-Id: I351e136b9925a53fb2273a394e17873c5533798d
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
This commit is contained in:
Nikolai Kosjar
2015-11-02 10:39:08 +01:00
parent 8f2ad8d246
commit 08fcb7f317
5 changed files with 45 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/unit/unittest/sourcerangetest.cpp
View File

@@ -85,9 +85,24 @@ protected:
translationUnits};
DiagnosticSet diagnosticSet{translationUnit.diagnostics()};
Diagnostic diagnostic{diagnosticSet.front()};
Diagnostic diagnosticWithFilteredOutInvalidRange{diagnosticSet.at(1)};
::SourceRange sourceRange{diagnostic.ranges().front()};
};
TEST_F(SourceRange, IsNull)
{
::SourceRange sourceRange;
ASSERT_TRUE(sourceRange.isNull());
}
TEST_F(SourceRange, IsNotNull)
{
::SourceRange sourceRange = diagnostic.ranges()[0];
ASSERT_FALSE(sourceRange.isNull());
}
TEST_F(SourceRange, Size)
{
ASSERT_THAT(diagnostic.ranges().size(), 2);
@@ -108,4 +123,10 @@ TEST_F(SourceRange, End)
6u,
44u));
}
TEST_F(SourceRange, InvalidRangeIsFilteredOut)
{
ASSERT_TRUE(diagnosticWithFilteredOutInvalidRange.ranges().empty());
}
}