feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Simplify range details

Browse Source 
There is no use in creating multiple nested maps and lists and
selecting special translation contexts for that.

Change-Id: Ib83ab651adca8258a0e5b9ac99a657623a24145b
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
This commit is contained in:
Ulf Hermann
2014-07-07 14:02:29 +02:00
parent b0a3b2950a
commit 092627f680
8 changed files with 28 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
src/plugins/qmlprofiler/qmlprofilertimelinemodelproxy.cpp
View File

@@ -287,51 +287,22 @@ QVariantList RangeTimelineModel::labels() const
return result;
}
QVariantList RangeTimelineModel::details(int index) const
QVariantMap RangeTimelineModel::details(int index) const
{
Q_D(const RangeTimelineModel);
QVariantList result;
QVariantMap result;
int id = eventId(index);
const QVector<QmlProfilerDataModel::QmlEventTypeData> &types =
d->modelManager->qmlModel()->getEventTypes();
static const char trContext[] = "RangeDetails";
{
QVariantMap valuePair;
valuePair.insert(QLatin1String("displayName"), QVariant(categoryLabel(d->rangeType)));
result << valuePair;
}
// duration
{
QVariantMap valuePair;
valuePair.insert(QCoreApplication::translate(trContext, "Duration:"),
QVariant(QmlProfilerBaseModel::formatTime(d->range(index).duration)));
result << valuePair;
}
// details
{
QVariantMap valuePair;
QString detailsString = types[id].data;
if (detailsString.length() > 40)
detailsString = detailsString.left(40) + QLatin1String("...");
valuePair.insert(QCoreApplication::translate(trContext, "Details:"),
QVariant(detailsString));
result << valuePair;
}
// location
{
QVariantMap valuePair;
valuePair.insert(QCoreApplication::translate(trContext, "Location:"),
QVariant(types[id].displayName));
result << valuePair;
}
// isbindingloop
{}
result.insert(QStringLiteral("displayName"), categoryLabel(d->rangeType));
result.insert(tr("Duration"), QmlProfilerBaseModel::formatTime(d->range(index).duration));
QString detailsString = types[id].data;
if (detailsString.length() > 40)
detailsString = detailsString.left(40) + QLatin1String("...");
result.insert(tr("Details"), detailsString);
result.insert(tr("Location"), types[id].displayName);
return result;
}