forked from qt-creator/qt-creator
Get attaching to a crashed Windows process right (CDB).
Handle the 2nd parameter correctly as a event id to be used for a handshake. Introduce a special mode when attaching to crashed processes. Code cleanup, pass StartParameters along to startDebugger.
This commit is contained in:
@@ -192,6 +192,7 @@ void DebuggerStartParameters::clear()
|
||||
buildDir.clear();
|
||||
attachPID = -1;
|
||||
useTerminal = false;
|
||||
crashParameter.clear();
|
||||
remoteChannel.clear();
|
||||
remoteArchitecture.clear();
|
||||
serverStartScript.clear();
|
||||
@@ -892,6 +893,7 @@ void DebuggerManager::startNewDebugger(DebuggerRunControl *runControl, const QSh
|
||||
QString settingsIdHint;
|
||||
switch (startMode()) {
|
||||
case AttachExternal:
|
||||
case AttachCrashedExternal:
|
||||
m_engine = determineDebuggerEngine(m_startParameters->attachPID, &errorMessage);
|
||||
break;
|
||||
case AttachTcf:
|
||||
@@ -919,7 +921,7 @@ void DebuggerManager::startNewDebugger(DebuggerRunControl *runControl, const QSh
|
||||
|
||||
setBusyCursor(false);
|
||||
setStatus(DebuggerProcessStartingUp);
|
||||
if (!m_engine->startDebugger()) {
|
||||
if (!m_engine->startDebugger(m_startParameters)) {
|
||||
setStatus(DebuggerProcessNotReady);
|
||||
debuggingFinished();
|
||||
return;
|
||||
|
||||
Reference in New Issue
Block a user