feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Use RAII pattern for parsing start/stop signalling

Browse Source 
Change-Id: I13de537140f265db3e3d0ab1cd924d6897cd90c8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Tobias Hunger
2019-08-06 14:46:37 +02:00
parent 8868989d5c
commit 09530d6dcc
18 changed files with 143 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/compilationdatabaseprojectmanager/compilationdbparser.h
View File

@@ -27,6 +27,8 @@
#include "compilationdatabaseutils.h"
#include <projectexplorer/project.h>
#include <utils/fileutils.h>
#include <QFutureWatcher>
@@ -48,15 +50,22 @@ class CompilationDbParser : public QObject
{
Q_OBJECT
public:
explicit CompilationDbParser(const QString &projectName, const Utils::FilePath &projectPath,
const Utils::FilePath &rootPath, MimeBinaryCache &mimeBinaryCache,
explicit CompilationDbParser(const QString &projectName,
const Utils::FilePath &projectPath,
const Utils::FilePath &rootPath,
MimeBinaryCache &mimeBinaryCache,
ProjectExplorer::Project::ParseGuard &&guard,
QObject *parent = nullptr);
void start();
void stop();
QList<ProjectExplorer::FileNode *> scannedFiles() const;
DbContents dbContents() const { return m_dbContents; }
DbContents dbContents() const
{
m_guard.markAsSuccess();
return m_dbContents;
}
signals:
void finished(bool success);
@@ -72,6 +81,8 @@ private:
ProjectExplorer::TreeScanner *m_treeScanner = nullptr;
QFutureWatcher<DbContents> m_parserWatcher;
DbContents m_dbContents;
ProjectExplorer::Project::ParseGuard m_guard;
};
} // namespace Internal