forked from qt-creator/qt-creator
Android: Remove AndroidRunnable::{beforeStart,afterFinish}AdbCommands
We have nowadays two ways to pass data from run configurations to tool that do not require intimate knowledge of the sender: 1. Using RunConfigurationAspects, accessible for all workers in a RunControl 2. Using RunWorker::recordData for an individual worker. This removes the need to use specific fields in a runnable and means that a tool plugin can be better separated from target plugins. The approaches are not mutually exclusive, both use an string-ish id, I chose here to use the same string when using both. This patch here uses approach 2. for the GammaRay/Android combo. It also fixes a (harmless) typo (s/POSTSTART/POSTFINISH). Change-Id: I4048693ca73b17253a39bfcacc9e1880ecf25736 Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
This commit is contained in:
@@ -87,6 +87,8 @@ protected:
|
||||
bool m_isPreNougat = false;
|
||||
AndroidRunnable m_androidRunnable;
|
||||
QString m_intentName;
|
||||
QStringList m_beforeStartAdbCommands;
|
||||
QStringList m_afterFinishAdbCommands;
|
||||
QString m_adb;
|
||||
QStringList m_amStartExtraArgs;
|
||||
qint64 m_processPID = -1;
|
||||
|
||||
Reference in New Issue
Block a user