feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Add a convenience overload for RefactoringFile::apply()

Browse Source 
... and make use of it.
In most contexts, apply() immediately follows setChangeSet(), so
combining the two can save a lot of code on the call site.

Change-Id: I421001bd47000cb64678a57b19760becf59a4863
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2024-05-22 13:31:08 +02:00
parent 708adca904
commit 09f747f7d1
37 changed files with 74 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/cppeditor/quickfixes/cppinsertvirtualmethods.cpp
View File

@@ -868,9 +868,8 @@ public:
// Write header file
if (!headerChangeSet.isEmpty()) {
headerFile->setChangeSet(headerChangeSet);
headerFile->setOpenEditor(true, m_insertPosDecl);
headerFile->apply();
headerFile->apply(headerChangeSet);
}
// Insert in implementation file
@@ -921,10 +920,8 @@ public:
implementationChangeSet.insert(insertPos, QLatin1String("\n\n") + defText);
}
if (!implementationChangeSet.isEmpty()) {
implementationFile->setChangeSet(implementationChangeSet);
implementationFile->apply();
}
if (!implementationChangeSet.isEmpty())
implementationFile->apply(implementationChangeSet);
}
}