CppCheck: Tr::tr and code cosmetics

Change-Id: I5e6583984f7dc94e998df3c20840f2ba2e801ab8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>

src/plugins/cppcheck/cppcheckdiagnosticview.cpp

@@ -3,15 +3,16 @@
 
 #include "cppcheckdiagnosticview.h"
 
+#include "cppchecktr.h"
+
 #include <coreplugin/editormanager/editormanager.h>
 
 #include <debugger/analyzer/diagnosticlocation.h>
 
-namespace Cppcheck {
-namespace Internal {
-
 using namespace Debugger;
 
+namespace Cppcheck::Internal {
+
 DiagnosticView::DiagnosticView(QWidget *parent)
     : DetailedErrorView(parent)
 {
@@ -21,7 +22,7 @@ DiagnosticView::DiagnosticView(QWidget *parent)
     setAutoScroll(false);
     sortByColumn(DiagnosticColumn, Qt::AscendingOrder);
     setObjectName("CppcheckIssuesView");
-    setWindowTitle(tr("Cppcheck Diagnostics"));
+    setWindowTitle(Tr::tr("Cppcheck Diagnostics"));
     setHeaderHidden(true);
 }
 
@@ -90,7 +91,4 @@ void DiagnosticView::mouseDoubleClickEvent(QMouseEvent *event)
     DetailedErrorView::mouseDoubleClickEvent(event);
 }
 
-} // namespace Internal
-} // namespace Cppcheck
-
-//#include "clangtoolsdiagnosticview.moc"
+} // Cppcheck::Internal