From 0a548fe2bc2857875b29cb9bb6ebf3fc84b0db39 Mon Sep 17 00:00:00 2001 From: Nikita Baryshnikov Date: Mon, 21 Aug 2017 11:47:33 +0300 Subject: [PATCH] ScxmlEditor.TransitionItem: fix signed overflow warning transitionitem.cpp:247: warning: assuming signed overflow does not occur when assuming that (X - c) <= X is always true [-Wstrict-overflow] if (idSnap >= 0 && idSnap < m_cornerPoints.count()) { ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: Icc0b21c21326663f801ffef2b82fdd4b2679bf07 Reviewed-by: Marco Benelli --- src/plugins/scxmleditor/plugin_interface/transitionitem.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/scxmleditor/plugin_interface/transitionitem.cpp b/src/plugins/scxmleditor/plugin_interface/transitionitem.cpp index 154324fd98d..acf0116ac6c 100644 --- a/src/plugins/scxmleditor/plugin_interface/transitionitem.cpp +++ b/src/plugins/scxmleditor/plugin_interface/transitionitem.cpp @@ -244,7 +244,7 @@ void TransitionItem::snapToAnyPoint(int id, const QPointF &newPoint, int diff) void TransitionItem::snapPointToPoint(int idSnap, const QPointF &p, int diff) { - if (idSnap >= 0 && idSnap < m_cornerPoints.count()) { + if (idSnap >= 0 && static_cast(idSnap) < static_cast(m_cornerPoints.count())) { if (qAbs(p.x() - m_cornerPoints[idSnap].x()) < diff) m_cornerPoints[idSnap].setX(p.x()); if (qAbs(p.y() - m_cornerPoints[idSnap].y()) < diff)