feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: Rework AndroidPacakgeInstallationStep

Browse Source 
It derived from MakeStep which is a rather odd base class for it, make
it derive from AbstractProcessStep instead. Also implement a config
widget for it. That one does nothing, but the old one didn't do
anything interesting either.

Change-Id: I76c2311580dbb62d08524fe0f77e803fd52ffbf4
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com>
Reviewed-by: BogDan Vatra <bogdan@kde.org>
This commit is contained in:
Daniel Teske
2013-10-10 16:12:16 +02:00
parent 4f82c36a19
commit 0a600e041a
2 changed files with 83 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/android/androidpackageinstallationstep.h
View File

@@ -30,12 +30,13 @@
#ifndef ANDROIDPACKAGEINSTALLATIONSTEP_H
#define ANDROIDPACKAGEINSTALLATIONSTEP_H
#include <qt4projectmanager/makestep.h>
#include <projectexplorer/buildstep.h>
#include <projectexplorer/abstractprocessstep.h>
namespace Android {
namespace Internal {
class AndroidPackageInstallationStep : public Qt4ProjectManager::MakeStep
class AndroidPackageInstallationStep : public ProjectExplorer::AbstractProcessStep
{
Q_OBJECT
friend class AndroidPackageInstallationFactory;
@@ -48,6 +49,9 @@ public:
bool fromMap(const QVariantMap &map);
QVariantMap toMap() const;
ProjectExplorer::BuildStepConfigWidget *createConfigWidget();
bool immutable() const;
private:
AndroidPackageInstallationStep(ProjectExplorer::BuildStepList *bc,
AndroidPackageInstallationStep *other);
@@ -55,6 +59,18 @@ private:
static const Core::Id Id;
};
class AndroidPackageInstallationStepWidget : public ProjectExplorer::BuildStepConfigWidget
{
public:
AndroidPackageInstallationStepWidget(AndroidPackageInstallationStep *step);
QString summaryText() const;
QString displayName() const;
bool showWidget() const;
private:
AndroidPackageInstallationStep *m_step;
};
} // namespace Internal
} // namespace Android