feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

RemoteLinux: Fix const correctness

Browse Source 
Amends c88a829059
Amends f9b4bcd3d8

Change-Id: Ia9817d4f7ba7df495e55e8729ba34258c907a545
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2022-11-24 20:55:54 +01:00
parent 4ad9f53989
commit 0a925009a1
2 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/remotelinux/tarpackagedeploystep.cpp
View File

@@ -59,7 +59,7 @@ bool TarPackageDeployService::isDeploymentNecessary() const
TaskItem TarPackageDeployService::uploadTask()
{
auto setupHandler = [this](FileTransfer &transfer) {
const auto setupHandler = [this](FileTransfer &transfer) {
const FilesToTransfer files {{m_packageFilePath,
deviceConfiguration()->filePath(remoteFilePath())}};
transfer.setFilesToTransfer(files);
@@ -67,10 +67,10 @@ TaskItem TarPackageDeployService::uploadTask()
this, &TarPackageDeployService::progressMessage);
emit progressMessage(Tr::tr("Uploading package to device..."));
};
auto doneHandler = [this](const FileTransfer &) {
const auto doneHandler = [this](const FileTransfer &) {
emit progressMessage(Tr::tr("Successfully uploaded package file."));
};
auto errorHandler = [this](const FileTransfer &transfer) {
const auto errorHandler = [this](const FileTransfer &transfer) {
const ProcessResultData result = transfer.resultData();
emit errorMessage(result.m_errorString);
};
@@ -79,7 +79,7 @@ TaskItem TarPackageDeployService::uploadTask()
TaskItem TarPackageDeployService::installTask()
{
auto setupHandler = [this](QtcProcess &process) {
const auto setupHandler = [this](QtcProcess &process) {
const QString cmdLine = QLatin1String("cd / && tar xvf ") + remoteFilePath()
+ " && (rm " + remoteFilePath() + " || :)";
process.setCommand({deviceConfiguration()->filePath("/bin/sh"), {"-c", cmdLine}});
@@ -92,11 +92,11 @@ TaskItem TarPackageDeployService::installTask()
});
emit progressMessage(Tr::tr("Installing package to device..."));
};
auto doneHandler = [this](const QtcProcess &) {
const auto doneHandler = [this](const QtcProcess &) {
saveDeploymentTimeStamp(DeployableFile(m_packageFilePath, {}), {});
emit progressMessage(Tr::tr("Successfully installed package file."));
};
auto errorHandler = [this](const QtcProcess &process) {
const auto errorHandler = [this](const QtcProcess &process) {
emit errorMessage(Tr::tr("Installing package failed.") + process.errorString());
};
return Process(setupHandler, doneHandler, errorHandler);
@@ -106,11 +106,11 @@ void TarPackageDeployService::doDeploy()
{
QTC_ASSERT(!m_taskTree, return);
auto finishHandler = [this] {
const auto finishHandler = [this] {
m_taskTree.release()->deleteLater();
stopDeployment();
};
Group root {
const Group root {
uploadTask(),
installTask(),
OnGroupDone(finishHandler),