From 0afd50aa3361b46069dbe32cfa11286ea950549e Mon Sep 17 00:00:00 2001 From: Tasuku Suzuki Date: Sat, 14 Oct 2023 14:15:15 +0900 Subject: [PATCH] Git: Improve upper part of layout MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In small screen, General Information and Commit Information fill more spaces than their importance. This commit changes their layout from vertical to horizontal. Change-Id: I919f1ac5fd02f32fda54698b012330ecebbd6ab0 Reviewed-by: Reviewed-by: André Hartmann Reviewed-by: Orgad Shaneh --- src/plugins/git/gitsubmiteditorwidget.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/plugins/git/gitsubmiteditorwidget.cpp b/src/plugins/git/gitsubmiteditorwidget.cpp index ec09437e266..c9b716df269 100644 --- a/src/plugins/git/gitsubmiteditorwidget.cpp +++ b/src/plugins/git/gitsubmiteditorwidget.cpp @@ -37,6 +37,7 @@ public: GitSubmitPanel() { repositoryLabel = new QLabel(Tr::tr("repository")); + repositoryLabel->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Preferred); branchLabel = new QLabel(Tr::tr("branch")); // FIXME: Isn't this overwritten soon? showHeadLabel = new QLabel("" + Tr::tr("Show HEAD") + ""); @@ -64,18 +65,18 @@ public: editGroup = new QGroupBox(Tr::tr("Commit Information")); Grid { - Tr::tr("Author:"), authorLineEdit, invalidAuthorLabel, st, br, + Tr::tr("Author:"), authorLineEdit, invalidAuthorLabel, br, Tr::tr("Email:"), emailLineEdit, invalidEmailLabel, br, empty, Row { bypassHooksCheckBox, signOffCheckBox, st } }.attachTo(editGroup); - Column { + Row { Group { title(Tr::tr("General Information")), Form { Tr::tr("Repository:"), repositoryLabel, br, Tr::tr("Branch:"), branchLabel, br, - Span(2, showHeadLabel) + empty, showHeadLabel } }, editGroup,