feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: let SubmitEditorWidget handle empty description

Browse Source 
SubmitEditorWidget::canSubmit() now return false if the description
field is empty. This avoids dummy code duplication in VCS plugins.

Change-Id: I11e4928e8eed432ccee6fa1f3516f0179a54625c
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Reviewed-by: Bill King <bill.king@nokia.com>
This commit is contained in:
Hugues Delorme
2011-11-22 15:04:58 +01:00
parent 19425b5e41
commit 0b67a513d6
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/git/gitsubmiteditorwidget.cpp
View File

@@ -154,11 +154,8 @@ void GitSubmitEditorWidget::setPanelData(const GitSubmitEditorPanelData &data)
bool GitSubmitEditorWidget::canSubmit() const
{
QString message = cleanupDescription(descriptionText()).trimmed();
if (m_gitSubmitPanelUi.invalidAuthorLabel->isVisible()
|| m_gitSubmitPanelUi.invalidEmailLabel->isVisible()
|| message.isEmpty())
|| m_gitSubmitPanelUi.invalidEmailLabel->isVisible())
return false;
return SubmitEditorWidget::canSubmit();
}