Utils: Rename QtcProcess::Result::Finished to FinishedWithSuccess

To make clear that this is not just any finish.

Also change FinishedError to FinishedWithError, to create
symmetry.

Also adapt enum member description to reality.

Change-Id: I13e05391eb86fdb24e2ae660f14dfddb282e1104
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

src/plugins/ios/iosconfigurations.cpp

@@ -237,7 +237,7 @@ static QByteArray decodeProvisioningProfile(const QString &path)
     // path is assumed to be valid file path to .mobileprovision
     p.setCommand({"openssl", {"smime", "-inform", "der", "-verify", "-in", path}});
     p.runBlocking();
-    if (p.result() != Utils::QtcProcess::Finished)
+    if (p.result() != Utils::QtcProcess::FinishedWithSuccess)
         qCDebug(iosCommonLog) << "Reading signed provisioning file failed" << path;
     return p.stdOut().toLatin1();
 }

src/plugins/ios/iosprobe.cpp

@@ -70,7 +70,7 @@ void XcodeProbe::detectDeveloperPaths()
     selectedXcode.setCommand({"/usr/bin/xcode-select", {"--print-path"}});
     selectedXcode.setProcessUserEventWhileRunning();
     selectedXcode.runBlocking();
-    if (selectedXcode.result() != QtcProcess::Finished)
+    if (selectedXcode.result() != QtcProcess::FinishedWithSuccess)
         qCWarning(probeLog)
                 << QString::fromLatin1("Could not detect selected Xcode using xcode-select");
     else

src/plugins/ios/simulatorcontrol.cpp

@@ -89,7 +89,7 @@ static bool runCommand(const CommandLine &command, QString *stdOutput, QString *
         *stdOutput = p.stdOut();
     if (allOutput)
         *allOutput = p.allOutput();
-    return p.result() == QtcProcess::Finished;
+    return p.result() == QtcProcess::FinishedWithSuccess;
 }
 
 static bool runSimCtlCommand(QStringList args, QString *output, QString *allOutput = nullptr)