feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangToolRunner: Move some methods into protected section

Browse Source 
As they are used only from subclasses.

Change-Id: Ic16ffe3af8417b74af8a0ad3ea7ed1219f1f3a01
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2023-01-06 13:13:52 +01:00
parent bf864ff371
commit 0c1077425f
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/clangtools/clangtoolrunner.h
View File

@@ -21,16 +21,12 @@ public:
ClangToolRunner(QObject *parent = nullptr); ClangToolRunner(QObject *parent = nullptr);
void init(const Utils::FilePath &outputDirPath, const Utils::Environment &environment); void init(const Utils::FilePath &outputDirPath, const Utils::Environment &environment);
void setName(const QString &name) { m_name = name; }
void setExecutable(const Utils::FilePath &executable) { m_executable = executable; }
void setArgsCreator(const ArgsCreator &argsCreator) { m_argsCreator = argsCreator; }
void setVFSOverlay(const QString overlayFilePath) { m_overlayFilePath = overlayFilePath; } void setVFSOverlay(const QString overlayFilePath) { m_overlayFilePath = overlayFilePath; }
QString name() const { return m_name; } QString name() const { return m_name; }
Utils::FilePath executable() const { return m_executable; } Utils::FilePath executable() const { return m_executable; }
QString fileToAnalyze() const { return m_fileToAnalyze; } QString fileToAnalyze() const { return m_fileToAnalyze; }
QString outputFilePath() const { return m_outputFilePath; } QString outputFilePath() const { return m_outputFilePath; }
QStringList mainToolArguments() const;
bool supportsVFSOverlay() const; bool supportsVFSOverlay() const;
// compilerOptions is expected to contain everything except: // compilerOptions is expected to contain everything except:
@@ -43,7 +39,10 @@ signals:
void finishedWithFailure(const QString &errorMessage, const QString &errorDetails); void finishedWithFailure(const QString &errorMessage, const QString &errorDetails);
protected: protected:
QString m_overlayFilePath; void setName(const QString &name) { m_name = name; }
void setExecutable(const Utils::FilePath &executable) { m_executable = executable; }
void setArgsCreator(const ArgsCreator &argsCreator) { m_argsCreator = argsCreator; }
QStringList mainToolArguments() const;
private: private:
void onProcessOutput(); void onProcessOutput();
@@ -51,7 +50,7 @@ private:
QString commandlineAndOutput() const; QString commandlineAndOutput() const;
private: QString m_overlayFilePath;
Utils::FilePath m_outputDirPath; Utils::FilePath m_outputDirPath;
Utils::QtcProcess m_process; Utils::QtcProcess m_process;