feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Don't expose Utils::defaultExitCodeInterpreter

Browse Source 
Instead, make its behavior implicit if none is given.

Change-Id: I3c1a054751a0afe22d0f40a2fed6dd00b5aef205
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2021-05-06 15:54:02 +02:00
parent ad5b34ab3e
commit 0c8d8c6b2a
8 changed files with 25 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/vcsbase/vcsbaseclient.cpp
View File

@@ -518,7 +518,7 @@ QString VcsBaseClient::vcsCommandString(VcsCommandTag cmd) const
ExitCodeInterpreter VcsBaseClient::exitCodeInterpreter(VcsCommandTag cmd) const
{
Q_UNUSED(cmd)
return Utils::defaultExitCodeInterpreter;
return {};
}
void VcsBaseClient::setDiffConfigCreator(ConfigCreator creator)

3
src/plugins/vcsbase/vcsbaseclient.h
View File

@@ -41,7 +41,6 @@
QT_BEGIN_NAMESPACE
class QFileInfo;
class QProcessEnvironment;
class QToolBar;
QT_END_NAMESPACE
@@ -82,7 +81,7 @@ public:
void enqueueJob(VcsCommand *cmd, const QStringList &args,
const QString &workingDirectory = QString(),
const Utils::ExitCodeInterpreter &interpreter = Utils::defaultExitCodeInterpreter) const;
const Utils::ExitCodeInterpreter &interpreter = {}) const;
virtual Utils::Environment processEnvironment() const;

2
src/plugins/vcsbase/vcscommand.h
View File

@@ -48,7 +48,7 @@ public:
Utils::SynchronousProcessResponse runCommand(const Utils::CommandLine &command,
int timeoutS,
const QString &workDirectory = QString(),
const Utils::ExitCodeInterpreter &interpreter = Utils::defaultExitCodeInterpreter) override;
const Utils::ExitCodeInterpreter &interpreter = {}) override;
private:
void emitRepositoryChanged(const QString &workingDirectory);