From 0cd74fe22e00bff01bcd610af6bdf8c814b3959b Mon Sep 17 00:00:00 2001 From: Marco Bubke Date: Wed, 13 Mar 2024 13:38:00 +0100 Subject: [PATCH] QmlDesigner: avoid extra widgetInfo() call widgetInfo() should be cheap but people make expensive stuff inside the call. So we should try to avoid to many calls. Change-Id: I66b0a5431471732dca934fc03efb307e2617fd65 Reviewed-by: Qt CI Patch Build Bot Reviewed-by: Thomas Hartmann Reviewed-by: Tim Jenssen --- src/plugins/qmldesigner/designercore/model/abstractview.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/plugins/qmldesigner/designercore/model/abstractview.cpp b/src/plugins/qmldesigner/designercore/model/abstractview.cpp index 061ab8ae2b0..125c7195a8f 100644 --- a/src/plugins/qmldesigner/designercore/model/abstractview.cpp +++ b/src/plugins/qmldesigner/designercore/model/abstractview.cpp @@ -567,8 +567,10 @@ void AbstractView::disableWidget() void AbstractView::enableWidget() { - if (hasWidget() && widgetInfo().widgetFlags == DesignerWidgetFlags::DisableOnError) - widgetInfo().widget->setEnabled(true); + if (hasWidget()) { + if (auto info = widgetInfo(); info.widgetFlags == DesignerWidgetFlags::DisableOnError) + info.widget->setEnabled(true); + } } QString AbstractView::contextHelpId() const