From 0ce92b3ac7f9ca93259471c3887b6bfc624fde61 Mon Sep 17 00:00:00 2001 From: hjk Date: Wed, 25 Nov 2020 10:25:08 +0100 Subject: [PATCH] Debugger: Adapt QXmlAttributes dumper to Qt6 Task-number: QTCREATORBUG-24098 Change-Id: I67ee0fae1308d20b474fe0dd565b46d2a83dd5e3 Reviewed-by: David Schulz --- share/qtcreator/debugger/qttypes.py | 9 +++++---- tests/auto/debugger/tst_dumpers.cpp | 3 ++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/share/qtcreator/debugger/qttypes.py b/share/qtcreator/debugger/qttypes.py index cff834aa235..b9cac650653 100644 --- a/share/qtcreator/debugger/qttypes.py +++ b/share/qtcreator/debugger/qttypes.py @@ -2202,10 +2202,11 @@ def qdump__QXmlAttributes__Attribute(d, value): def qdump__QXmlAttributes(d, value): - (vptr, atts) = value.split('pP') - innerType = d.createType(d.qtNamespace() + 'QXmlAttributes::Attribute', 4 * d.ptrSize()) - val = d.createListItem(atts, innerType) - qdumpHelper_QList(d, val, innerType) + vptr, atts = value.split('p{QList}') + _, att_size, _ = d.describeStruct('{QString}' * 4) + innerType = d.createType(d.qtNamespace() + 'QXmlAttributes::Attribute', + att_size) + qdumpHelper_QList(d, atts, innerType) def qdump__QXmlStreamStringRef(d, value): diff --git a/tests/auto/debugger/tst_dumpers.cpp b/tests/auto/debugger/tst_dumpers.cpp index 9adf8543c33..aed514301f7 100644 --- a/tests/auto/debugger/tst_dumpers.cpp +++ b/tests/auto/debugger/tst_dumpers.cpp @@ -1050,7 +1050,8 @@ public: { this->operator+(CoreProfile()); profileExtra += - " QT += xml\n"; + "greaterThan(QT_MAJOR_VERSION, 5): QT += core5compat\n" + "else: QT += xml\n"; cmakelistsExtra += "find_package(Qt5 COMPONENTS Core Xml REQUIRED)\n"