feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Fix crash in gtest support

Browse Source 
If the parser processes a test with an empty test name
it crashed QC.

Change-Id: Ic377f609ecdd74724ee7a272be3d5b60f0101afa
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2021-05-12 14:37:41 +02:00
parent 5574deebe0
commit 0cef9a8554
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/autotest/gtest/gtestvisitors.cpp
View File

@@ -94,8 +94,12 @@ bool GTestVisitor::visit(CPlusPlus::FunctionDefinitionAST *ast)
testCaseName.clear(); testCaseName.clear();
} }
} else { } else {
const CPlusPlus::Argument *testSuiteNameArg = ast->symbol->argumentAt(0)->asArgument(); const CPlusPlus::Symbol *firstArg = ast->symbol->argumentAt(0);
const CPlusPlus::Argument *testCaseNameArg = ast->symbol->argumentAt(1)->asArgument(); const CPlusPlus::Symbol *secondArg = ast->symbol->argumentAt(1);
if (!firstArg || !secondArg)
return false;
const CPlusPlus::Argument *testSuiteNameArg = firstArg->asArgument();
const CPlusPlus::Argument *testCaseNameArg = secondArg->asArgument();
if (testSuiteNameArg && testCaseNameArg) { if (testSuiteNameArg && testCaseNameArg) {
testSuiteName = m_overview.prettyType(testSuiteNameArg->type()); testSuiteName = m_overview.prettyType(testSuiteNameArg->type());
testCaseName = m_overview.prettyType(testCaseNameArg->type()); testCaseName = m_overview.prettyType(testCaseNameArg->type());