feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Changed property insertion into one-liners.

Browse Source
This commit is contained in:
Erik Verbruggen
2010-03-19 12:01:29 +01:00
parent ed31fdd2ae
commit 0cf0fb463b
1 changed files with 29 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/plugins/qmldesigner/core/filemanager/addpropertyvisitor.cpp
View File

@@ -105,6 +105,25 @@ void AddPropertyVisitor::addInMembers(QmlJS::AST::UiObjectInitializer *initializ
depth = calculateIndentDepth(endOfPreviousMember); depth = calculateIndentDepth(endOfPreviousMember);
} }
const bool isOneLiner = endOfPreviousMember.startLine == startOfNextMember.startLine;
bool needsPreceedingSemicolon = false;
bool needsTrailingSemicolon = false;
if (isOneLiner) {
if (insertAfter == 0) { // we're inserting after an lbrace
if (insertAfter->next) { // we're inserting before a member (and not the rbrace)
needsTrailingSemicolon = true;
}
} else { // we're inserting after a member, not after the lbrace
if (endOfPreviousMember.isValid()) { // there already is a semicolon after the previous member
if (insertAfter->next && insertAfter->next->member) { // and the after us there is a member, not an rbrace, so:
needsTrailingSemicolon = true;
}
} else { // there is no semicolon after the previous member (probably because there is an rbrace after us/it, so:
needsPreceedingSemicolon = true;
}
}
}
QString newPropertyTemplate; QString newPropertyTemplate;
switch (m_propertyType) { switch (m_propertyType) {
@@ -125,12 +144,18 @@ void AddPropertyVisitor::addInMembers(QmlJS::AST::UiObjectInitializer *initializ
Q_ASSERT(!"unknown property type"); Q_ASSERT(!"unknown property type");
} }
const bool isOneLiner = endOfPreviousMember.startLine == startOfNextMember.startLine; if (isOneLiner) {
if (isOneLiner) if (needsPreceedingSemicolon)
newPropertyTemplate += QLatin1Char('\n'); newPropertyTemplate.prepend(QLatin1Char(';'));
newPropertyTemplate.prepend(QLatin1Char(' '));
if (needsTrailingSemicolon)
newPropertyTemplate.append(QLatin1Char(';'));
} else {
newPropertyTemplate.prepend(QLatin1Char('\n'));
}
const QString newPropertyText = addIndentation(newPropertyTemplate.arg(m_name, m_value), depth); const QString newPropertyText = addIndentation(newPropertyTemplate.arg(m_name, m_value), depth);
replace(endOfPreviousMember.end(), 0, QLatin1Char('\n') + newPropertyText); replace(endOfPreviousMember.end(), 0, newPropertyText);
setDidRewriting(true); setDidRewriting(true);
} }