feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

GitLab: Handle certificate issues

Browse Source 
Allow to bypass certificate verifications.
Currently the bypassing is not stored into the settings,
so this is not permanent.

Change-Id: Ieb564464a28cf2d4973c6b1baa696d6c22b07177
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2022-06-08 09:00:23 +02:00
parent fdb413c9a7
commit 0cfd264279
5 changed files with 42 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/gitlab/queryrunner.cpp
View File

@@ -102,9 +102,10 @@ QString Query::toString() const
QueryRunner::QueryRunner(const Query &query, const Utils::Id &id, QObject *parent)
: QObject(parent)
, m_serverId(id)
{
const GitLabParameters *p = GitLabPlugin::globalParameters();
const auto server = p->serverForId(id);
const auto server = p->serverForId(m_serverId);
QStringList args = server.curlArguments();
m_paginated = query.hasPaginatedResults();
if (m_paginated)
@@ -161,7 +162,18 @@ void QueryRunner::processFinished()
if (m_process.exitStatus() != QProcess::NormalExit) {
errorTermination(tr("%1 crashed.").arg(executable));
return;
} else if (m_process.exitCode()) {
} else if (int exitCode = m_process.exitCode()) {
if (exitCode == 35 || exitCode == 60) { // common ssl certificate issues
if (GitLabPlugin::handleCertificateIssue(m_serverId)) {
m_running = false;
// prepend -k for re-requesting the same query
Utils::CommandLine cmdline = m_process.commandLine();
cmdline.prependArgs({"-k"});
m_process.setCommand(cmdline);
start();
return;
}
}
errorTermination(tr("%1 returned %2.").arg(executable).arg(m_process.exitCode()));
return;
}