feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Simplify check state handling

Browse Source 
Data functions and special functions cannot be checked at all, so
there is no need to inherit the state by its parent.

Change-Id: If72f79ef6bcd77628916bd7fbe137faa5555db41
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
This commit is contained in:
Christian Stenger
2015-09-04 10:57:05 +02:00
parent 274d095f46
commit 0d01a0c7bf
1 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/autotest/testtreeitem.cpp
View File

@@ -30,21 +30,10 @@ TestTreeItem::TestTreeItem(const QString &name, const QString &filePath, Type ty
m_parent(parent) m_parent(parent)
{ {
switch (m_type) { switch (m_type) {
case ROOT:
m_checked = Qt::Unchecked;
break;
case TEST_CLASS: case TEST_CLASS:
case TEST_FUNCTION: case TEST_FUNCTION:
m_checked = Qt::Checked; m_checked = Qt::Checked;
break; break;
case TEST_DATAFUNCTION:
case TEST_SPECIALFUNCTION:
if (m_parent)
m_checked = m_parent->checked() == Qt::PartiallyChecked ? Qt::Unchecked
: m_parent->checked();
else
m_checked = Qt::Unchecked;
break;
default: default:
m_checked = Qt::Unchecked; m_checked = Qt::Unchecked;
} }
@@ -169,7 +158,7 @@ Qt::CheckState TestTreeItem::checked() const
return m_checked; return m_checked;
case TEST_DATAFUNCTION: case TEST_DATAFUNCTION:
case TEST_SPECIALFUNCTION: case TEST_SPECIALFUNCTION:
return m_parent->m_checked == Qt::PartiallyChecked ? Qt::Unchecked : m_parent->m_checked; return Qt::Unchecked;
default: default:
if (m_parent) if (m_parent)
return m_parent->m_checked; return m_parent->m_checked;