feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Removed the gray border around the open editors widget

Browse Source 
It looks wrong when a shadow is added, which a lot of window managers do
these days. Whether is looks better when no shadow is added by the
window manager is debatable.

Reviewed-by: Jens Bache-Wiig
This commit is contained in:
Thorbjørn Lindeijer
2010-04-13 15:30:11 +02:00
parent e07821855c
commit 0d04949d1c
3 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/coreplugin/editormanager/openeditorswindow.cpp
View File

@@ -45,9 +45,8 @@ Q_DECLARE_METATYPE(Core::IFile *)
using namespace Core; using namespace Core;
using namespace Core::Internal; using namespace Core::Internal;
const int OpenEditorsWindow::WIDTH = 300; const int WIDTH = 300;
const int OpenEditorsWindow::HEIGHT = 200; const int HEIGHT = 200;
const int OpenEditorsWindow::MARGIN = 4;
OpenEditorsWindow::OpenEditorsWindow(QWidget *parent) : OpenEditorsWindow::OpenEditorsWindow(QWidget *parent) :
QWidget(parent, Qt::Popup), QWidget(parent, Qt::Popup),
@@ -64,7 +63,7 @@ OpenEditorsWindow::OpenEditorsWindow(QWidget *parent) :
m_editorList->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOn); m_editorList->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOn);
#endif #endif
m_editorList->installEventFilter(this); m_editorList->installEventFilter(this);
m_editorList->setGeometry(MARGIN, MARGIN, WIDTH-2*MARGIN, HEIGHT-2*MARGIN); m_editorList->setGeometry(0, 0, WIDTH, HEIGHT);
connect(m_editorList, SIGNAL(itemClicked(QTreeWidgetItem*, int)), connect(m_editorList, SIGNAL(itemClicked(QTreeWidgetItem*, int)),
this, SLOT(editorClicked(QTreeWidgetItem*))); this, SLOT(editorClicked(QTreeWidgetItem*)));
@@ -90,7 +89,7 @@ bool OpenEditorsWindow::isCentering()
QRect rect0 = m_editorList->visualItemRect(m_editorList->topLevelItem(0)); QRect rect0 = m_editorList->visualItemRect(m_editorList->topLevelItem(0));
QRect rect1 = m_editorList->visualItemRect(m_editorList->topLevelItem(m_editorList->topLevelItemCount()-1)); QRect rect1 = m_editorList->visualItemRect(m_editorList->topLevelItem(m_editorList->topLevelItemCount()-1));
int height = rect1.y() + rect1.height() - rect0.y(); int height = rect1.y() + rect1.height() - rect0.y();
height += 2*internalMargin + 2*MARGIN; height += 2 * internalMargin;
if (height > HEIGHT) if (height > HEIGHT)
return true; return true;
return false; return false;

4
src/plugins/coreplugin/editormanager/openeditorswindow.h
View File

@@ -73,10 +73,6 @@ private slots:
void selectEditor(QTreeWidgetItem *item); void selectEditor(QTreeWidgetItem *item);
private: private:
static const int WIDTH;
static const int HEIGHT;
static const int MARGIN;
static void updateItem(QTreeWidgetItem *item, IEditor *editor); static void updateItem(QTreeWidgetItem *item, IEditor *editor);
void ensureCurrentVisible(); void ensureCurrentVisible();
bool isCentering(); bool isCentering();

4
src/plugins/help/openpagesswitcher.cpp
View File

@@ -39,7 +39,6 @@
using namespace Help::Internal; using namespace Help::Internal;
const int gMargin = 4;
const int gWidth = 300; const int gWidth = 300;
const int gHeight = 200; const int gHeight = 200;
@@ -53,8 +52,7 @@ OpenPagesSwitcher::OpenPagesSwitcher(OpenPagesModel *model)
m_openPagesWidget->allowContextMenu(false); m_openPagesWidget->allowContextMenu(false);
m_openPagesWidget->installEventFilter(this); m_openPagesWidget->installEventFilter(this);
m_openPagesWidget->setGeometry(gMargin, gMargin, gWidth - 2 * gMargin, m_openPagesWidget->setGeometry(0, 0, gWidth, gHeight);
gHeight - 2 * gMargin);
connect(m_openPagesWidget, SIGNAL(closePage(QModelIndex)), this, connect(m_openPagesWidget, SIGNAL(closePage(QModelIndex)), this,
SIGNAL(closePage(QModelIndex))); SIGNAL(closePage(QModelIndex)));