feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify use of AbstractProcessStep::init()

Browse Source 
1. Systematically check for AbstractProcessStep::init() first in
   derived classes.
2. Use setupProcessParameters(processParameters()); by default in
   the base implementation.
3. Drop all re-implementations that are effectively the same.

Change-Id: I0ae54dd4909b354672a63ee56d0b7c2ea0732494
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2020-09-14 17:17:55 +02:00
parent 9f378d41e4
commit 0d185a0ad3
23 changed files with 47 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/autotoolsprojectmanager/autogenstep.cpp
View File

@@ -63,7 +63,6 @@ public:
AutogenStep(BuildStepList *bsl, Utils::Id id);
private:
bool init() override;
void doRun() override;
StringAspect *m_additionalArgumentsAspect = nullptr;
@@ -98,13 +97,6 @@ AutogenStep::AutogenStep(BuildStepList *bsl, Utils::Id id) : AbstractProcessStep
});
}
bool AutogenStep::init()
{
ProcessParameters *pp = processParameters();
setupProcessParameters(pp);
return AbstractProcessStep::init();
}
void AutogenStep::doRun()
{
// Check whether we need to run autogen.sh