Fix qbs code style

Change-Id: Ia3e4df528d391580064efbeeab75016335a4299d
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>

qbs/pluginspec/pluginspec.qbs

@@ -2,7 +2,7 @@ import qbs.base 1.0
 import qbs.fileinfo 1.0 as FileInfo
 
 Module {
-    Depends { id: qtcore; name: "qt.core" }
+    Depends { id: qtcore; name: "Qt.core" }
 
     additionalProductFileTags: qtcore.versionMajor < 5 ? ["pluginSpec"] : ["pluginJSON"]
     property int ide_version_major: project.ide_version_major
@@ -49,7 +49,7 @@ Module {
                 var inf = new TextFile(input.fileName);
                 var all = inf.readAll();
                 // replace quoted quotes
-                all = all.replace(/\\\"/g, "\"");
+                all = all.replace(/\\\"/g, '"');
                 // replace config vars
                 vars['QTCREATOR_VERSION'] = qtcreator_version;
                 vars['IDE_VERSION_MAJOR'] = ide_version_major;
@@ -83,8 +83,11 @@ Module {
             var xslFile = project.path + "/src/pluginjsonmetadata.xsl";
             var xmlPatternsPath = product.modules["qt/core"].binPath + "/xmlpatterns";
             var args = [
-                "-no-format", "-output", output.fileName,
+                "-no-format",
-                xslFile, input.fileName
+                "-output",
+                output.fileName,
+                xslFile,
+                input.fileName
             ];
             var cmd = new Command(xmlPatternsPath, args);
             cmd.description = "generating " + FileInfo.fileName(output.fileName);

qtcreator.qbp

@@ -106,7 +106,7 @@ Project {
                     var file = new TextFile(input.fileName);
                     var content = file.readAll();
                     // replace quoted quotes
-                    content = content.replace(/\\\"/g, "\"");
+                    content = content.replace(/\\\"/g, '"');
                     // replace Windows line endings
                     if (onWindows)
                         content = content.replace(/\r\n/g, "\n");

src/libs/3rdparty/botan/botan.qbs

@@ -5,14 +5,16 @@ QtcLibrary {
     name: "Botan"
 
     Depends { name: "cpp" }
-    Depends { name: "qt"; submodules: 'core' }
+    Depends { name: "Qt.core" }
 
-    cpp.includePaths: ["build", "src"]
+    cpp.includePaths: [
+        "build",
+        "src"
+    ]
     cpp.dynamicLibraries: {
-        if (qbs.targetOS == 'linux' || qbs.targetOS == 'freebsd') {
+        if (qbs.targetOS == "linux" || qbs.targetOS == "freebsd") {
-            return ['rt']
+            return ["rt"]
-        }
+        } else if (qbs.targetOS == "windows") {
-        else if (qbs.targetOS == 'windows') {
             return [
                 "advapi32",
                 "user32"
@@ -22,17 +24,17 @@ QtcLibrary {
 
     cpp.defines: {
         var result = []
-        if (qbs.toolchain == 'msvc2005' || qbs.toolchain == 'msvc2008' || qbs.toolchain == 'msvc2010')
+        if (qbs.toolchain == "msvc2005" || qbs.toolchain == "msvc2008" || qbs.toolchain == "msvc2010")
-            result.push('BOTAN_DLL=__declspec(dllexport)')
+            result.push("BOTAN_DLL=__declspec(dllexport)")
         return result
     }
 
     Properties {
-        condition: qbs.toolchain === 'mingw'
+        condition: qbs.toolchain == "mingw"
         cpp.cxxFlags: [
-            '-fpermissive',
+            "-fpermissive",
-            '-finline-functions',
+            "-finline-functions",
-            '-Wno-long-long'
+            "-Wno-long-long"
         ]
     }
 
@@ -500,7 +502,7 @@ QtcLibrary {
     }
 
     Group {
-        condition: qbs.targetOS == "linux" || qbs.targetOS == 'mac'
+        condition: qbs.targetOS == "linux" || qbs.targetOS == "mac"
         files: [
             "src/alloc/alloc_mmap/mmap_mem.cpp",
             "src/cert/cvc/asn1_eac_str.cpp",
@@ -545,8 +547,8 @@ QtcLibrary {
     ProductModule {
         Depends { name: "cpp" }
         cpp.linkerFlags: {
-            if (qbs.toolchain === 'mingw') {
+            if (qbs.toolchain == "mingw") {
-                return ['--enable-auto-import']
+                return ["--enable-auto-import"]
             }
         }
     }

src/libs/QtcLibrary.qbs

@@ -2,7 +2,7 @@ import qbs.base 1.0
 
 DynamicLibrary {
     destination: {
-        if (qbs.targetOS === "windows")
+        if (qbs.targetOS == "windows")
             return "bin"
         else
             return "lib/qtcreator"

src/libs/glsl/glsl.qbs

@@ -17,13 +17,34 @@ QtcLibrary {
     Depends { name: "Qt.gui" }
 
     files: [
-        "glsl.h", "glsllexer.h", "glslparser.h", "glslparsertable_p.h", "glslast.h",
+        "glsl.h",
-        "glslastvisitor.h", "glslengine.h", "glslmemorypool.h", "glslastdump.h",
+        "glsllexer.h",
-        "glslsemantic.h", "glsltype.h", "glsltypes.h", "glslsymbol.h", "glslsymbols.h",
+        "glslparser.h",
-        "glslkeywords.cpp", "glslparser.cpp", "glslparsertable.cpp",
+        "glslparsertable_p.h",
-        "glsllexer.cpp", "glslast.cpp",
+        "glslast.h",
-        "glslastvisitor.cpp", "glslengine.cpp", "glslmemorypool.cpp", "glslastdump.cpp",
+        "glslastvisitor.h",
-        "glslsemantic.cpp", "glsltype.cpp", "glsltypes.cpp", "glslsymbol.cpp", "glslsymbols.cpp",
+        "glslengine.h",
+        "glslmemorypool.h",
+        "glslastdump.h",
+        "glslsemantic.h",
+        "glsltype.h",
+        "glsltypes.h",
+        "glslsymbol.h",
+        "glslsymbols.h",
+        "glslkeywords.cpp",
+        "glslparser.cpp",
+        "glslparsertable.cpp",
+        "glsllexer.cpp",
+        "glslast.cpp",
+        "glslastvisitor.cpp",
+        "glslengine.cpp",
+        "glslmemorypool.cpp",
+        "glslastdump.cpp",
+        "glslsemantic.cpp",
+        "glsltype.cpp",
+        "glsltypes.cpp",
+        "glslsymbol.cpp",
+        "glslsymbols.cpp",
         "glsl.g"
     ]
 

src/libs/qmldebug/qmldebug.qbs

@@ -13,8 +13,7 @@ QtcLibrary {
     ]
 
     Depends { name: "cpp" }
-    Depends { name: "Qt.gui" }
+    Depends { name: "Qt"; submodules: ["gui", "network"] }
-    Depends { name: "Qt.network" }
     Depends { name: "symbianutils" }
 
     files: [
@@ -50,9 +49,7 @@ QtcLibrary {
     ProductModule {
         Depends { name: "cpp" }
         Depends { name: "symbianutils" }
-        cpp.includePaths: [
+        cpp.includePaths: ["."]
-            "."
-        ]
     }
 }
 

src/libs/qmljs/qmljs.qbs

@@ -18,7 +18,7 @@ QtcLibrary {
     Depends { name: "Utils" }
     Depends { name: "LanguageUtils" }
     Depends { name: "cpp" }
-    Depends { name: "Qt"; submodules: ['widgets', 'script'] }
+    Depends { name: "Qt"; submodules: ["widgets", "script"] }
 
     files: [
         "qmljs.qrc",

src/libs/qtcomponents/styleitem/styleitem.qbs

@@ -5,7 +5,7 @@ DynamicLibrary {
     destination: "lib/qtcreator/qtcomponents/plugin"
 
     Depends { name: "cpp" }
-    Depends { name: "Qt"; submodules: ['core', 'widgets', 'quick1', 'script'] }
+    Depends { name: "Qt"; submodules: ["core", "widgets", "quick1", "script"] }
 
     files: [
         "qdeclarativefolderlistmodel.cpp",

src/libs/ssh/ssh.qbs

@@ -5,14 +5,16 @@ QtcLibrary {
     name: "QtcSsh"
 
     cpp.defines: ["QSSH_LIBRARY"]
-    cpp.includePaths: [ ".", "..",
+    cpp.includePaths: [
+        ".",
+        "..",
         "../..",
         "../3rdparty/botan/build",
         buildDirectory
     ]
 
     Depends { name: "cpp" }
-    Depends { name: "Qt"; submodules: ['widgets', 'network' ] }
+    Depends { name: "Qt"; submodules: ["widgets", "network" ] }
     Depends { name: "Botan" }
 
     files: [
@@ -50,6 +52,6 @@ QtcLibrary {
     ProductModule {
         Depends { name: "cpp" }
         Depends { name: "Qt"; submodules: ["widgets", "network"] }
-        cpp.includePaths: ".."
+        cpp.includePaths: [".."]
     }
 }

src/libs/symbianutils/symbianutils.qbs

@@ -20,7 +20,7 @@ QtcLibrary {
     cpp.optimization: "fast"
 
     Depends { name: "cpp" }
-    Depends { name: "Qt"; submodules: ["network"]}
+    Depends { name: "Qt.network" }
     Depends { name: "Utils" }
 
     Group {

src/libs/utils/process_ctrlc_stub.qbs

@@ -4,11 +4,14 @@ import "../../tools/QtcTool.qbs" as QtcTool
 QtcTool {
     name: "qtcreator_ctrlc_stub"
     consoleApplication: true
-    condition: qbs.targetOS === "windows"
+    condition: qbs.targetOS == "windows"
 
     Depends { name: "cpp" }
 
     files: [ "process_ctrlc_stub.cpp" ]
 
-    cpp.dynamicLibraries: [ "user32.lib", "shell32.lib" ]
+    cpp.dynamicLibraries: [
+        "user32.lib",
+        "shell32.lib"
+    ]
 }

src/libs/utils/process_stub.qbs

@@ -8,7 +8,7 @@ QtcTool {
     Depends { name: "cpp" }
 
     files: {
-        if (qbs.targetOS === "windows") {
+        if (qbs.targetOS == "windows") {
             return [ "process_stub_win.c" ]
         } else {
             return [ "process_stub_unix.c" ]
@@ -16,7 +16,7 @@ QtcTool {
     }
 
     cpp.dynamicLibraries: {
-        if (qbs.targetOS === "windows") {
+        if (qbs.targetOS == "windows") {
             return [ "shell32.lib" ]
         }
     }

src/libs/utils/utils.qbs

@@ -5,22 +5,28 @@ QtcLibrary {
     name: "Utils"
 
     cpp.defines: ["QTCREATOR_UTILS_LIB"]
-    cpp.includePaths: [ ".", "..",
+    cpp.includePaths: [
+        ".",
+        "..",
         "../..",
         buildDirectory
     ]
 
     Properties {
         condition: qbs.targetOS == "windows"
-        cpp.dynamicLibraries: ["user32", "iphlpapi", "ws2_32"]
+        cpp.dynamicLibraries: [
+            "user32",
+            "iphlpapi",
+            "ws2_32"
+        ]
     }
     Properties {
-        condition: qbs.targetOS === "linux"
+        condition: qbs.targetOS == "linux"
         cpp.dynamicLibraries: ["X11"]
     }
 
     Depends { name: "cpp" }
-    Depends { name: "Qt"; submodules: ['widgets', 'network', 'script', 'concurrent'] }
+    Depends { name: "Qt"; submodules: ["widgets", "network", "script", "concurrent"] }
     Depends { name: "app_version_header" }
 
     files: [

src/libs/zeroconf/zeroconf.qbs

@@ -25,9 +25,12 @@ QtcLibrary {
     }
 
     files: [
-        "servicebrowser.cpp", "servicebrowser.h", "servicebrowser_p.h",
+        "servicebrowser.cpp",
+        "servicebrowser.h",
+        "servicebrowser_p.h",
         "embeddedLib.cpp",
-        "mdnsderived.cpp", "mdnsderived.h",
+        "mdnsderived.cpp",
+        "mdnsderived.h",
         "avahiLib.cpp",
         "dnsSdLib.cpp",
         "dns_sd_types.h",
@@ -37,6 +40,6 @@ QtcLibrary {
 
     ProductModule {
         Depends { name: "cpp" }
-        cpp.includePaths: "."
+        cpp.includePaths: ["."]
     }
 }

src/plugins/analyzerbase/analyzerbase.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "AnalyzerBase"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "CppTools" }
     Depends { name: "RemoteLinux" }
@@ -13,7 +13,10 @@ QtcPlugin {
     Depends { name: "TextEditor" }
 
     Depends { name: "cpp" }
-    cpp.defines: ["ANALYZER_LIBRARY", "QT_NO_CAST_FROM_ASCII"]
+    cpp.defines: [
+        "ANALYZER_LIBRARY",
+        "QT_NO_CAST_FROM_ASCII"
+    ]
     cpp.includePaths: [
         "..",
         "../../libs",
@@ -55,9 +58,7 @@ QtcPlugin {
 
     ProductModule {
         Depends { name: "cpp" }
-        cpp.includePaths: [
+        cpp.includePaths: ["."]
-            "."
-        ]
 
         Depends { name: "CPlusPlus" }
     }

src/plugins/android/android.qbs

@@ -10,7 +10,7 @@ QtcPlugin {
     Depends { name: "Qt4ProjectManager" }
     Depends { name: "Debugger" }
     Depends { name: "QtSupport" }
-    Depends { name: "qt"; submodules: ['widgets', 'xml', 'network'] }
+    Depends { name: "Qt"; submodules: ["widgets", "xml", "network"] }
 
     property bool enable: false
     property var pluginspecreplacements: ({"ANDROID_EXPERIMENTAL_STR": (enable ? "false": "true")})

src/plugins/autotoolsprojectmanager/autotoolsprojectmanager.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "AutotoolsProjectManager"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "ProjectExplorer" }
     Depends { name: "QtSupport" }

src/plugins/bazaar/bazaar.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Bazaar"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "TextEditor" }
     Depends { name: "Find" }

src/plugins/bineditor/bineditor.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "BinEditor"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "TextEditor" }
     Depends { name: "Find" }

src/plugins/bookmarks/bookmarks.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Bookmarks"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "ProjectExplorer" }
     Depends { name: "TextEditor" }
@@ -31,6 +31,3 @@ QtcPlugin {
     ]
 }
 
-
-
-

src/plugins/classview/classview.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "ClassView"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "CppTools" }
     Depends { name: "CPlusPlus" }

src/plugins/cmakeprojectmanager/cmakeprojectmanager.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "CMakeProjectManager"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "ProjectExplorer" }
     Depends { name: "CppTools" }

src/plugins/coreplugin/coreplugin.qbs

@@ -5,10 +5,9 @@ QtcPlugin {
     name: "Core"
 
     Depends {
-        name: "qt"
+        name: "Qt"
         submodules: [
-            'core', 'widgets', 'xml', 'network',
+            "core", "widgets", "xml", "network", "script", "sql", "help", "printsupport"
-            'script', 'sql', 'help', 'printsupport'
         ]
     }
     Depends { name: "Utils" }
@@ -30,7 +29,7 @@ QtcPlugin {
     ]
 
     cpp.dynamicLibraries: {
-        if (qbs.targetOS == 'windows') return [
+        if (qbs.targetOS == "windows") return [
             "ole32"
         ]
     }

src/plugins/cpaster/cpaster.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "CodePaster"
 
-    Depends { name: "qt"; submodules: ['widgets', 'network'] }
+    Depends { name: "Qt"; submodules: ["widgets", "network"] }
     Depends { name: "Core" }
     Depends { name: "TextEditor" }
 

src/plugins/cppeditor/cppeditor.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "CppEditor"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "CppTools" }
     Depends { name: "CPlusPlus" }

src/plugins/cpptools/cpptools.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "CppTools"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "Find" }
     Depends { name: "TextEditor" }

src/plugins/cvs/cvs.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "CVS"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "TextEditor" }
     Depends { name: "Find" }

src/plugins/debugger/debugger.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Debugger"
 
-    Depends { name: "qt"; submodules: ['widgets', 'network', 'script'] }
+    Depends { name: "Qt"; submodules: ["widgets", "network", "script"] }
     Depends { name: "Core" }
     Depends { name: "CppTools" }
     Depends { name: "QmlJSTools" }

src/plugins/designer/designer.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Designer"
 
-    Depends { name: "qt"; submodules: ['widgets', 'xml', 'printsupport', 'designer', 'designercomponents'] }
+    Depends { name: "Qt"; submodules: ["widgets", "xml", "printsupport", "designer", "designercomponents"] }
     Depends { name: "Core" }
     Depends { name: "CPlusPlus" }
     Depends { name: "CppTools" }
@@ -89,6 +89,3 @@ QtcPlugin {
     ]
 }
 
-
-
-

src/plugins/fakevim/fakevim.qbs

@@ -9,7 +9,7 @@ QtcPlugin {
     Depends { name: "TextEditor" }
     Depends { name: "Find" }
     Depends { name: "cpp" }
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
 
     cpp.includePaths: [
         "..",

src/plugins/find/find.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Find"
 
-    Depends { name: "qt"; submodules: ['widgets', 'xml', 'network', 'script'] }
+    Depends { name: "Qt"; submodules: ["widgets", "xml", "network", "script"] }
     Depends { name: "Core" }
     Depends { name: "cpp" }
 

src/plugins/genericprojectmanager/genericprojectmanager.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "GenericProjectManager"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "CPlusPlus" }
     Depends { name: "CppTools" }

src/plugins/git/git.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Git"
 
-    Depends { name: "qt"; submodules: ['widgets', 'network'] }
+    Depends { name: "Qt"; submodules: ["widgets", "network"] }
     Depends { name: "Core" }
     Depends { name: "TextEditor" }
     Depends { name: "Find" }

src/plugins/glsleditor/glsleditor.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "GLSLEditor"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "TextEditor" }
     Depends { name: "ProjectExplorer" }

src/plugins/helloworld/helloworld.qbs

@@ -7,7 +7,7 @@ QtcPlugin {
 
     Depends { name: "Core" }
     Depends { name: "cpp" }
-    Depends { name: "qt"; submodules: ['widgets', 'xml', 'network', 'script'] }
+    Depends { name: "Qt"; submodules: ["widgets", "xml", "network", "script"] }
 
     cpp.includePaths: [
         "..",

src/plugins/imageviewer/imageviewer.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "ImageViewer"
 
-    Depends { name: "qt"; submodules: ['widgets', 'svg'] }
+    Depends { name: "Qt"; submodules: ["widgets", "svg"] }
     Depends { name: "Core" }
 
     Depends { name: "cpp" }
@@ -35,6 +35,3 @@ QtcPlugin {
     ]
 }
 
-
-
-

src/plugins/locator/locator.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Locator"
 
-    Depends { name: "qt"; submodules: ['widgets', 'xml', 'network', 'script'] }
+    Depends { name: "Qt"; submodules: ["widgets", "xml", "network", "script"] }
     Depends { name: "Core" }
     Depends { name: "cpp" }
 

src/plugins/macros/macros.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Macros"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "Locator" }
     Depends { name: "Find" }
@@ -54,6 +54,3 @@ QtcPlugin {
     ]
 }
 
-
-
-

src/plugins/mercurial/mercurial.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Mercurial"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "TextEditor" }
     Depends { name: "Find" }

src/plugins/perforce/perforce.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Perforce"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "TextEditor" }
     Depends { name: "Find" }

src/plugins/projectexplorer/projectexplorer.qbs

@@ -4,7 +4,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "ProjectExplorer"
 
-    Depends { name: "qt"; submodules: ['widgets', 'xml', 'network', 'script', 'quick1'] }
+    Depends { name: "Qt"; submodules: ["widgets", "xml", "network", "script", "quick1"] }
     Depends { name: "Core" }
     Depends { name: "Locator" }
     Depends { name: "Find" }

src/plugins/qmldesigner/qmldesigner.qbs

@@ -5,9 +5,9 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "QmlDesigner"
 
-    condition: qtcore.versionMajor === 4
+    condition: qtcore.versionMajor == 4
-    Depends { id: qtcore; name: "qt.core" }
+    Depends { id: qtcore; name: "Qt.core" }
-    Depends { name: "qt"; submodules: ['widgets', 'quick1'] }
+    Depends { name: "Qt"; submodules: ["widgets", "quick1"] }
     Depends { name: "Core" }
     Depends { name: "QmlJS" }
     Depends { name: "QmlEditorWidgets" }

src/plugins/qmljseditor/qmljseditor.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "QmlJSEditor"
 
-    Depends { name: "qt"; submodules: ['widgets', 'script'] }
+    Depends { name: "Qt"; submodules: ["widgets", "script"] }
     Depends { name: "Core" }
     Depends { name: "TextEditor" }
     Depends { name: "ProjectExplorer" }
@@ -26,7 +26,7 @@ QtcPlugin {
     ]
 
     files: [
-         "qmljseditor.qrc",
+        "qmljseditor.qrc",
         "quicktoolbarsettingspage.ui",
         "QmlJSEditor.mimetypes.xml",
         "jsfilewizard.cpp",

src/plugins/qmljstools/qmljstools.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "QmlJSTools"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "LanguageUtils" }
     Depends { name: "CppTools" }

src/plugins/qmlprofiler/qmlprofiler.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "QmlProfiler"
 
-    Depends { name: "qt"; submodules: ['widgets', 'network', 'script', 'quick1'] }
+    Depends { name: "Qt"; submodules: ["widgets", "network", "script", "quick1"] }
     Depends { name: "Core" }
     Depends { name: "AnalyzerBase" }
     Depends { name: "QmlProjectManager" }

src/plugins/qmlprojectmanager/qmlprojectmanager.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "QmlProjectManager"
 
-    Depends { name: "qt"; submodules: ['widgets', 'quick1'] }
+    Depends { name: "Qt"; submodules: ["widgets", "quick1"] }
     Depends { name: "Core" }
     Depends { name: "ProjectExplorer" }
     Depends { name: "TextEditor" }
@@ -58,6 +58,3 @@ QtcPlugin {
     ]
 }
 
-
-
-

src/plugins/qt4projectmanager/qt4projectmanager.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Qt4ProjectManager"
 
-    Depends { name: "qt"; submodules: ['widgets', 'network'] }
+    Depends { name: "Qt"; submodules: ["widgets", "network"] }
     Depends { name: "Core" }
     Depends { name: "ProjectExplorer" }
     Depends { name: "QtSupport" }

src/plugins/qtsupport/qtsupport.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "QtSupport"
 
-    Depends { name: "qt"; submodules: ['widgets', 'quick1'] }
+    Depends { name: "Qt"; submodules: ["widgets", "quick1"] }
     Depends { name: "Core" }
     Depends { name: "ProjectExplorer" }
     Depends { name: "TextEditor" }

src/plugins/remotelinux/remotelinux.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "RemoteLinux"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "Debugger" }
     Depends { name: "ProjectExplorer" }

src/plugins/resourceeditor/resourceeditor.qbs

@@ -8,7 +8,7 @@ QtcPlugin {
     Depends { name: "Core" }
     Depends { name: "Find" }
     Depends { name: "cpp" }
-    Depends { name: "qt"; submodules: ['widgets', 'xml'] }
+    Depends { name: "Qt"; submodules: ["widgets", "xml"] }
 
     cpp.includePaths: [
         "..",

src/plugins/subversion/subversion.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Subversion"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "TextEditor" }
     Depends { name: "Find" }

src/plugins/tasklist/tasklist.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "TaskList"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "ProjectExplorer" }
     Depends { name: "Find" }
@@ -35,6 +35,3 @@ QtcPlugin {
     ]
 }
 
-
-
-

src/plugins/texteditor/texteditor.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "TextEditor"
 
-    Depends { name: "qt"; submodules: ['widgets', 'xml', 'network', 'script', 'printsupport'] }
+    Depends { name: "Qt"; submodules: ["widgets", "xml", "network", "script", "printsupport"] }
     Depends { name: "cpp" }
     Depends { name: "Core" }
     Depends { name: "Find" }

src/plugins/todo/todo.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Todo"
 
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "Core" }
     Depends { name: "TextEditor" }
     Depends { name: "ProjectExplorer" }

src/plugins/valgrind/valgrind.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Valgrind"
 
-    Depends { name: "qt"; submodules: ['widgets', 'network'] }
+    Depends { name: "Qt"; submodules: ["widgets", "network"] }
     Depends { name: "Core" }
     Depends { name: "AnalyzerBase" }
     Depends { name: "ProjectExplorer" }

src/plugins/vcsbase/vcsbase.qbs

@@ -10,7 +10,7 @@ QtcPlugin {
     Depends { name: "ProjectExplorer" }
     Depends { name: "Find" }
     Depends { name: "cpp" }
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "CppTools" }
     Depends { name: "CPlusPlus" }
 

src/plugins/welcome/welcome.qbs

@@ -5,7 +5,7 @@ import "../QtcPlugin.qbs" as QtcPlugin
 QtcPlugin {
     name: "Welcome"
 
-    Depends { name: "qt"; submodules: ['widgets', 'network', 'quick1'] }
+    Depends { name: "Qt"; submodules: ["widgets", "network", "quick1"] }
     Depends { name: "Core" }
     Depends { name: "ProjectExplorer" }
 

src/tools/mdnssd/mdnssd.qbs

@@ -5,18 +5,30 @@ import "../QtcTool.qbs" as QtcTool
 QtcTool {
     name: "mdnssd"
 
-    cpp.defines: [ "PID_FILE=\"/tmp/mdnsd.pid\"", "MDNS_UDS_SERVERPATH=\"/tmp/mdnsd\"",
+    cpp.defines: [
-        "MDNS_DEBUGMSGS=0", "HAVE_IPV6" ]
+        'PID_FILE="/tmp/mdnsd.pid"',
-    cpp.includePaths: [ ".",  buildDirectory ]
+        'MDNS_UDS_SERVERPATH="/tmp/mdnsd"',
+        "MDNS_DEBUGMSGS=0",
+        "HAVE_IPV6"
+    ]
+    cpp.includePaths: [
+        ".",
+        buildDirectory
+    ]
 
     Depends { name: "cpp" }
 
     files: [
-        "uds_daemon.c", "uds_daemon.h",
+        "uds_daemon.c",
-        "uDNS.c", "uDNS.h",
+        "uds_daemon.h",
-        "mDNSDebug.c", "mDNSDebug.h",
+        "uDNS.c",
-        "GenLinkedList.c", "GenLinkedList.h",
+        "uDNS.h",
-        "dnssd_ipc.c", "dnssd_ipc.h",
+        "mDNSDebug.c",
+        "mDNSDebug.h",
+        "GenLinkedList.c",
+        "GenLinkedList.h",
+        "dnssd_ipc.c",
+        "dnssd_ipc.h",
         "DNSDigest.c",
         "DNSCommon.c",
         "mDNSUNP.h",
@@ -24,29 +36,34 @@ QtcTool {
         "DNSCommon.h",
         "DebugServices.h",
         "dns_sd.h",
-        "mDNS.c",
+        "mDNS.c"
     ]
 
     Group {
-        condition: qbs.targetOS === "linux"
+        condition: qbs.targetOS == "linux"
         files: [
-            "mDNSPosix.c",  "mDNSPosix.h",
+            "mDNSPosix.c",
-            "PlatformCommon.c", "PlatformCommon.h",
+            "mDNSPosix.h",
+            "PlatformCommon.c",
+            "PlatformCommon.h",
             "PosixDaemon.c",
             "mDNSUNP.c"
         ]
     }
 
     Properties {
-        condition: qbs.targetOS === "linux"
+        condition: qbs.targetOS == "linux"
         cpp.defines: outer.concat([
-            "_GNU_SOURCE", "NOT_HAVE_SA_LEN",
+            "_GNU_SOURCE",
-            "USES_NETLINK", "HAVE_LINUX", "TARGET_OS_LINUX"
+            "NOT_HAVE_SA_LEN",
+            "USES_NETLINK",
+            "HAVE_LINUX",
+            "TARGET_OS_LINUX"
         ])
     }
 
     Properties {
-        condition: qbs.targetOS === "macx"
+        condition: qbs.targetOS == "macx"
         cpp.defines: outer.concat([
             "__MAC_OS_X_VERSION_MIN_REQUIRED=__MAC_OS_X_VERSION_10_4",
             "__APPLE_USE_RFC_2292"
@@ -54,13 +71,18 @@ QtcTool {
     }
 
     Group {
-        condition: qbs.targetOS === "windows"
+        condition: qbs.targetOS == "windows"
         files: [
-            "Firewall.h", "Firewall.cpp",
+            "Firewall.h",
-            "mDNSWin32.h", "mDNSWin32.c",
+            "Firewall.cpp",
-            "Poll.h", "Poll.c",
+            "mDNSWin32.h",
-            "Secret.h", "Secret.c",
+            "mDNSWin32.c",
-            "Service.h", "Service.c",
+            "Poll.h",
+            "Poll.c",
+            "Secret.h",
+            "Secret.c",
+            "Service.h",
+            "Service.c",
             "DebugServices.c",
             "LegacyNATTraversal.c",
             "resource.h",
@@ -73,24 +95,47 @@ QtcTool {
     }
 
     Properties {
-        condition: qbs.targetOS === "windows"
+        condition: qbs.targetOS == "windows"
         cpp.includePaths: outer.concat([buildDirectory + "/" + name])
         cpp.defines: outer.concat([
             "WIN32",
-            "_WIN32_WINNT=0x0501", "NDEBUG", "MDNS_DEBUGMSGS=0", "TARGET_OS_WIN32",
+            "_WIN32_WINNT=0x0501",
-            "WIN32_LEAN_AND_MEAN", "USE_TCP_LOOPBACK", "PLATFORM_NO_STRSEP",
+            "NDEBUG",
-            "PLATFORM_NO_EPIPE", "PLATFORM_NO_RLIMIT", "UNICODE", "_UNICODE",
+            "MDNS_DEBUGMSGS=0",
-            "_CRT_SECURE_NO_DEPRECATE", "_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1",
+            "TARGET_OS_WIN32",
+            "WIN32_LEAN_AND_MEAN",
+            "USE_TCP_LOOPBACK",
+            "PLATFORM_NO_STRSEP",
+            "PLATFORM_NO_EPIPE",
+            "PLATFORM_NO_RLIMIT",
+            "UNICODE",
+            "_UNICODE",
+            "_CRT_SECURE_NO_DEPRECATE",
+            "_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1",
             "_LEGACY_NAT_TRAVERSAL_"
         ])
-        cpp.dynamicLibraries: [ "ws2_32.lib", "advapi32.lib", "ole32.lib", "oleaut32.lib",
+        cpp.dynamicLibraries: [
-            "iphlpapi.lib", "netapi32.lib", "user32.lib", "powrprof.lib", "shell32.lib" ]
+            "ws2_32.lib",
+            "advapi32.lib",
+            "ole32.lib",
+            "oleaut32.lib",
+            "iphlpapi.lib",
+            "netapi32.lib",
+            "user32.lib",
+            "powrprof.lib",
+            "shell32.lib"
+        ]
     }
 
     Properties {
-        condition: qbs.toolchain === 'mingw' || qbs.toolchain === 'gcc'
+        condition: qbs.toolchain == 'mingw' || qbs.toolchain == 'gcc'
-        cpp.cFlags: [ "-Wno-unused-but-set-variable", "-Wno-strict-aliasing" ]
+        cpp.cFlags: [
-        cpp.cxxFlags: [ "-Wno-unused-but-set-variable" ]
+            "-Wno-unused-but-set-variable",
+            "-Wno-strict-aliasing"
+        ]
+        cpp.cxxFlags: [
+            "-Wno-unused-but-set-variable"
+        ]
     }
 
     FileTagger {

src/tools/qtcdebugger/qtcdebugger.qbs

@@ -3,13 +3,19 @@ import "../QtcTool.qbs" as QtcTool
 
 QtcTool {
     name: "qtcdebugger"
-    condition: qbs.targetOS === "windows"
+    condition: qbs.targetOS == "windows"
 
-    cpp.includePaths: [ buildDirectory, "../../shared/registryaccess" ]
+    cpp.includePaths: [
-    cpp.dynamicLibraries: [ "psapi", "advapi32" ]
+        buildDirectory,
+        "../../shared/registryaccess"
+    ]
+    cpp.dynamicLibraries: [
+        "psapi",
+        "advapi32"
+    ]
 
     Depends { name: "cpp" }
-    Depends { name: "qt"; submodules: ['widgets'] }
+    Depends { name: "Qt.widgets" }
     Depends { name: "app_version_header" }
 
     files: [

src/tools/qtpromaker/qtpromaker.qbs

@@ -5,7 +5,7 @@ QtcTool {
     name: "qtpromaker"
 
     Depends { name: "cpp" }
-    Depends { name: "qt"; submodules: ['core'] }
+    Depends { name: "Qt.core" }
 
     files: [ "main.cpp" ]
 }