From 0d60ee3906b367cba75dc7d8953b0814e8952d12 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 3 Jun 2020 13:45:30 +0200 Subject: [PATCH] Fix clang warnings about unwanted copies in range loops Change-Id: I11ae3317fd251a463809ee48917d2daf0f8b43d1 Reviewed-by: Christian Stenger --- src/libs/cplusplus/LookupContext.cpp | 3 +-- src/plugins/android/androidconfigurations.cpp | 2 +- src/plugins/android/androidtoolmanager.cpp | 2 +- .../qmldesigner/components/connectioneditor/delegates.cpp | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/libs/cplusplus/LookupContext.cpp b/src/libs/cplusplus/LookupContext.cpp index d4776418ca0..e02d6e5073a 100644 --- a/src/libs/cplusplus/LookupContext.cpp +++ b/src/libs/cplusplus/LookupContext.cpp @@ -1142,8 +1142,7 @@ ClassOrNamespace *ClassOrNamespace::nestedType(const Name *name, int maximumArgumentsMatched = 0; - for (const std::pair &p : - specializations) { + for (const auto &p : specializations) { const TemplateNameId *templateSpecialization = p.first; ClassOrNamespace *specializationClassOrNamespace = p.second; diff --git a/src/plugins/android/androidconfigurations.cpp b/src/plugins/android/androidconfigurations.cpp index f787b86eddd..4e34cbba84f 100644 --- a/src/plugins/android/androidconfigurations.cpp +++ b/src/plugins/android/androidconfigurations.cpp @@ -616,7 +616,7 @@ QVector AndroidConfig::connectedDevices(const FilePath &adbTo if (adbDevs.empty()) return devices; - for (const QString line : adbDevs) // remove the daemon logs + for (const QString &line : adbDevs) // remove the daemon logs if (line.startsWith("* daemon")) adbDevs.removeOne(line); adbDevs.removeFirst(); // remove "List of devices attached" header line diff --git a/src/plugins/android/androidtoolmanager.cpp b/src/plugins/android/androidtoolmanager.cpp index fa88a4987f8..7c7eaad6789 100644 --- a/src/plugins/android/androidtoolmanager.cpp +++ b/src/plugins/android/androidtoolmanager.cpp @@ -206,7 +206,7 @@ AndroidDeviceInfoList AndroidToolManager::androidVirtualDevices(const Utils::Fil if (avds.empty()) return devices; - for (const QString line : avds) // remove the daemon logs + for (const QString &line : avds) // remove the daemon logs if (line.startsWith("* daemon")) avds.removeOne(line); diff --git a/src/plugins/qmldesigner/components/connectioneditor/delegates.cpp b/src/plugins/qmldesigner/components/connectioneditor/delegates.cpp index 7a308b08999..82e97fae210 100644 --- a/src/plugins/qmldesigner/components/connectioneditor/delegates.cpp +++ b/src/plugins/qmldesigner/components/connectioneditor/delegates.cpp @@ -309,7 +309,7 @@ QWidget *ConnectionDelegate::createEditor(QWidget *parent, const QStyleOptionVie } QStringList trigger = connectionModel->getflowActionTriggerForRow(index.row()); - for (const QString action : trigger) { + for (const QString &action : trigger) { connectionComboBox->addItem(tr("Activate FlowAction %1").arg(nameForAction(action)), action); } }