feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Mercurial: Move plugin pimpl to .cpp

Browse Source 
And remove a couple of singleton accesses and indirections.

Change-Id: Ib54a0e5c580b5354d2b700de02034cce506d8017
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2020-01-29 12:50:48 +01:00
parent 0f67026794
commit 0dadf19c91
9 changed files with 153 additions and 205 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/mercurial/srcdestdialog.h
View File

@@ -26,6 +26,7 @@
#pragma once
#include <utils/pathchooser.h>
#include <vcsbase/vcsbaseplugin.h>
#include <QDialog>
namespace Mercurial {
@@ -39,7 +40,7 @@ class SrcDestDialog : public QDialog
public:
enum Direction { outgoing, incoming };
explicit SrcDestDialog(Direction dir, QWidget *parent = nullptr);
explicit SrcDestDialog(const VcsBase::VcsBasePluginState &state, Direction dir, QWidget *parent = nullptr);
~SrcDestDialog() override;
void setPathChooserKind(Utils::PathChooser::Kind kind);
@@ -53,6 +54,7 @@ private:
Ui::SrcDestDialog *m_ui;
Direction m_direction;
mutable QString m_workingdir;
VcsBase::VcsBasePluginState m_state;
};
} // namespace Internal