feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Compile fix: Don't use Utils::FileName's private constructor

Browse Source 
error: C2248: 'Utils::FileName::FileName': cannot access private member
declared in class 'Utils::FileName'

Change-Id: I0d7169170d4c360fce038c43c6572acc6760bddf
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Alessandro Portale
2018-03-01 18:35:29 +01:00
committed by Orgad Shaneh
parent ec571d86fd
commit 0db9df2806
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/debugger/debuggerkitinformation.cpp
View File

@@ -114,7 +114,7 @@ void DebuggerKitInformation::setup(Kit *k)
// This improves the situation a bit if a cross-compilation tool chain has the // This improves the situation a bit if a cross-compilation tool chain has the
// same ABI as the host. // same ABI as the host.
if (level == DebuggerItem::MatchesPerfectly if (level == DebuggerItem::MatchesPerfectly
&& systemEnvironment.path().contains(item.command().parentDir().toString())) { && systemEnvironment.path().contains(item.command().parentDir())) {
level = DebuggerItem::MatchesPerfectlyInPath; level = DebuggerItem::MatchesPerfectlyInPath;
} }
} else if (rawId.type() == QVariant::String) { } else if (rawId.type() == QVariant::String) {

2
src/plugins/qmakeprojectmanager/qmakekitinformation.cpp
View File

@@ -103,7 +103,7 @@ void QmakeKitInformation::setup(Kit *k)
const Environment systemEnvironment = Environment::systemEnvironment(); const Environment systemEnvironment = Environment::systemEnvironment();
ToolChain *bestTc = Utils::findOrDefault(goodTcs, ToolChain *bestTc = Utils::findOrDefault(goodTcs,
[&systemEnvironment](const ToolChain *t) { [&systemEnvironment](const ToolChain *t) {
return systemEnvironment.path().contains(t->compilerCommand().parentDir().toString()); return systemEnvironment.path().contains(t->compilerCommand().parentDir());
}); });
if (!bestTc) { if (!bestTc) {
bestTc = goodTcs.isEmpty() ? possibleTcs.last() : goodTcs.last(); bestTc = goodTcs.isEmpty() ? possibleTcs.last() : goodTcs.last();