Core: Move VcsManager test class definition closer to tested code

Change-Id: Ibc97d4874eca871d7d283dc97bf61235e9ea5539
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

src/plugins/coreplugin/coreplugin.cpp

@@ -14,6 +14,7 @@
 #include "session.h"
 #include "settingsdatabase.h"
 #include "themechooser.h"
+#include "vcsmanager.h"
 
 #include "actionmanager/actionmanager.h"
 #include "coreconstants.h"
@@ -244,6 +245,10 @@ bool CorePlugin::initialize(const QStringList &arguments, QString *errorMessage)
             Qt::QueuedConnection);
 #endif
 
+#ifdef WITH_TESTS
+    addTestCreator(&createVcsManagerTest);
+#endif
+
     return true;
 }
 

src/plugins/coreplugin/coreplugin.h

@@ -62,8 +62,6 @@ public slots:
 
 #if defined(WITH_TESTS)
 private slots:
-    void testVcsManager_data();
-    void testVcsManager();
     // Locator:
     void test_basefilefilter();
     void test_basefilefilter_data();

src/plugins/coreplugin/vcsmanager.cpp

@@ -440,8 +440,6 @@ void VcsManager::handleConfigurationChanges(IVersionControl *vc)
 
 #include <QtTest>
 
-#include "coreplugin.h"
-
 #include <extensionsystem/pluginmanager.h>
 
 namespace Core {
@@ -471,7 +469,16 @@ static QString makeString(const QString &s)
     return QString::fromLatin1(TEST_PREFIX) + s;
 }
 
-void CorePlugin::testVcsManager_data()
+class VcsManagerTest final : public QObject
+{
+    Q_OBJECT
+
+private slots:
+    void testVcsManager_data();
+    void testVcsManager();
+};
+
+void VcsManagerTest::testVcsManager_data()
 {
     // avoid conflicts with real files and directories:
 
@@ -523,7 +530,7 @@ void CorePlugin::testVcsManager_data()
             << QStringList({"a/2:a:A:*"});
 }
 
-void CorePlugin::testVcsManager()
+void VcsManagerTest::testVcsManager()
 {
     // setup:
     QList<IVersionControl *> orig = Core::d->m_versionControlList;
@@ -578,7 +585,14 @@ void CorePlugin::testVcsManager()
     Core::d->m_versionControlList = orig;
 }
 
+QObject *createVcsManagerTest()
+{
+    return new VcsManagerTest;
+}
+
 } // namespace Internal
 } // namespace Core
 
 #endif
+
+#include "vcsmanager.moc"

src/plugins/coreplugin/vcsmanager.h

@@ -91,4 +91,8 @@ private:
     friend class IVersionControl;
 };
 
+#ifdef WITH_TESTS
+namespace Internal { QObject *createVcsManagerTest(); }
+#endif
+
 } // namespace Core